Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend e2e and unit test coverage for ScaledJob #3661

Open
Tracked by #2357
zroubalik opened this issue Sep 14, 2022 · 2 comments · May be fixed by #5499
Open
Tracked by #2357

Extend e2e and unit test coverage for ScaledJob #3661

zroubalik opened this issue Sep 14, 2022 · 2 comments · May be fixed by #5499
Assignees
@geoffrey1330
Labels
feature-request All issues for new features that have not been committed to good first issue Good for newcomers help wanted Looking for support from community stale-bot-ignore All issues that should not be automatically closed by our stale bot testing

Comments

@zroubalik
Copy link
Member

zroubalik commented Sep 14, 2022 •
edited by JorTurFer

Proposal

  • Cover advanced options/scaling strategies of ScaledJob in e2e tests.
  • Add some unit tests for the scaledjob_controller.go

Use-Case

No response

Anything else?

No response
@zroubalik zroubalik added help wanted Looking for support from community feature-request All issues for new features that have not been committed to testing labels Sep 14, 2022
@JorTurFer JorTurFer added the good first issue Good for newcomers label Nov 6, 2022
@stale
Copy link

stale bot commented Jan 13, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@zroubalik zroubalik added the stale-bot-ignore All issues that should not be automatically closed by our stale bot label Jan 13, 2023
@JorTurFer JorTurFer mentioned this issue Jan 23, 2023
Open
35 tasks
@JorTurFer JorTurFer changed the title Extend e2e test coverage for ScaledJob Extend e2e and unit test coverage for ScaledJob Apr 24, 2023
@geoffrey1330
Copy link
Contributor

Hi @JorTurFer could you please assign this issue to me
cc @zroubalik

@geoffrey1330 geoffrey1330 linked a pull request Feb 12, 2024 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geoffrey1330 geoffrey1330

Labels
feature-request All issues for new features that have not been committed to good first issue Good for newcomers help wanted Looking for support from community stale-bot-ignore All issues that should not be automatically closed by our stale bot testing
Projects
Roadmap - KEDA Core
Status: Proposed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added some unit tests for the scaledjob_controller.go geoffrey1330/keda
4 participants
@zroubalik @tomkerkhove @JorTurFer @geoffrey1330