Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added some unit tests for the scaledjob_controller.go #5499

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Added some unit tests for the scaledjob_controller.go #5499

wants to merge 31 commits into from

Conversation

geoffrey1330
Copy link
Contributor

@geoffrey1330 geoffrey1330 commented Feb 12, 2024 •
edited

Signed-off-by: geoffrey1330 israelgeoffrey13@gmail.com

Provide a description of what has been changed

Checklist

Fixes #3661

Relates to #2357

@geoffrey1330
Added some unit tests for the scaledjob_controller.go
fb263ff 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330 geoffrey1330 requested a review from a team as a code owner February 12, 2024 13:15
JorTurFer
JorTurFer reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good! Thanks for the improvement ❤️

Could you add more validations to cover the typical errors? You can check what's tested for ScaledObject controller: https://github.com/kedacore/keda/blob/main/controllers/keda/scaledobject_controller_test.go

controllers/keda/scaledjob_controller_test.go Outdated Show resolved Hide resolved
controllers/keda/scaledjob_controller_test.go Outdated Show resolved Hide resolved
controllers/keda/scaledjob_controller_test.go Show resolved Hide resolved
controllers/keda/scaledjob_controller_test.go Outdated Show resolved Hide resolved
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
9866422 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
cf7dc5c 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
695a33f 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
53f5533 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
JorTurFer
JorTurFer reviewed Feb 15, 2024
View reviewed changes
config/crd/bases/eventing.keda.sh_cloudeventsources.yaml Outdated Show resolved Hide resolved
config/crd/bases/keda.sh_clustertriggerauthentications.yaml Outdated Show resolved Hide resolved
config/crd/bases/keda.sh_scaledobjects.yaml Outdated Show resolved Hide resolved
config/crd/bases/keda.sh_triggerauthentications.yaml Outdated Show resolved Hide resolved
config/metrics-server/kustomization.yaml Outdated Show resolved Hide resolved
config/webhooks/kustomization.yaml Outdated Show resolved Hide resolved
config/manager/kustomization.yaml Outdated Show resolved Hide resolved
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
b6ed923 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
368dc32 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Merge branch 'main' into feat/extend_test_coverage_scaledjob
47e3f9f
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
f100665 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@JorTurFer
Copy link
Member

The new test is failing with with error: [FAILED] Expected jobs to be created

@geoffrey1330
Added some unit tests for the scaledjob_controller.go
9332ad3 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
bcd8e0c 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
9ebd83e 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
9aa0412 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
49eeb9e 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
fa5ff15 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
dbfa337 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
152f654 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
3c2b3e9 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
9982416 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
c06bda2 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
8395af3 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
5cc2ab6 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
50098df 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
8de128b 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
ab009c3 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
c2322eb 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
14addeb 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
81e628d 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
5904f1a 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Added some unit tests for the scaledjob_controller.go
92628c9 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
@geoffrey1330
Merge branch 'main' into feat/extend_test_coverage_scaledjob
4159e3f
@tomkerkhove
Copy link
Member

@geoffrey1330 Any update on this PR?

@geoffrey1330
Copy link
Contributor Author

@geoffrey1330 Any update on this PR?

Nothing yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend e2e and unit test coverage for ScaledJob
3 participants
@geoffrey1330 @JorTurFer @tomkerkhove