Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub-Runner scaler discovering only first repo list page #5738

Closed
KoblerS opened this issue Apr 24, 2024 · 0 comments · Fixed by #5746
Closed

GitHub-Runner scaler discovering only first repo list page #5738

KoblerS opened this issue Apr 24, 2024 · 0 comments · Fixed by #5746
Labels
bug Something isn't working

Comments

@KoblerS
Copy link
Contributor

KoblerS commented Apr 24, 2024

Report

The GitHub runner scaler only discovers repositories on the first page of the "list-repositories" rest api request. Especially if a organisation exceeds the limit for the first page, see GitHub API reference: https://docs.github.com/en/rest/repos/repos?apiVersion=2022-11-28#list-organization-repositories

Per default GitHub only returns first 30 repositories and further repos need to be paginated.

Expected Behavior

It should discover all repos in the organisation by paginating through.

Actual Behavior

Right now only first 30 repositories are retrieved and if the the corresponding repository is on the second or third page then KEDA will not scale up

Steps to Reproduce the Problem

  1. Create a bunch of repositories in the organization > 30
  2. Make sure that the corresponding repo that should be builded is not the first page in the rest API
  3. KEDA will not scale based on this repository

Logs from KEDA operator

No response

KEDA Version

2.12.1

Kubernetes Version

None

Platform

Microsoft Azure

Scaler Details

Azure Container App Job

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant