-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue when GitHub organization contains more than 30 repos #5746
Conversation
cb09c29
to
e4bebde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement! Could you include a unit test for this case too?
@JorTurFer sure will work on it! |
877071d
to
bb1d675
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KoblerS could you please fix the DCO problem?
bb1d675
to
ac9dcd2
Compare
could you please check again. Thanks! |
Semgrep found 1 Consider to use well-defined context Ignore this finding from context-todo. |
41618ff
to
72b0d88
Compare
Signed-off-by: Simon Kobler <github@kobler.me>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com> Signed-off-by: Simon Kobler <github@kobler.me>
Signed-off-by: Simon Kobler <github@kobler.me>
Signed-off-by: Simon Kobler <github@kobler.me>
72b0d88
to
9adbf62
Compare
Signed-off-by: Simon Kobler <32038731+KoblerS@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also some problems in the imports:
@@ -2,13 +2,13 @@ package scalers
import (
"context"
+ "crypto/rand"
"encoding/json"
"fmt"
- "crypto/rand"
+ "html/template"
"math/big"
"net/http"
"net/http/httptest"
- "html/template"
"strings"
"testing"
"time"
Signed-off-by: Simon Kobler <github@kobler.me>
@KoblerS you can see the failed static check output: https://github.com/kedacore/keda/actions/runs/9127598269/job/25098204457?pr=5746 |
Signed-off-by: Simon Kobler <github@kobler.me>
0833290
to
ee9a242
Compare
sorry didn't saw it, should be fixed now. |
/run-e2e github |
Any updates when this will be merged? |
Fixed issue when GitHub organization contains more than 30 repositories. Scaler will now iterate over the pages according to GitHubs documentation.
Checklist
Fixes #5738