Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable smoke test for ARM arch #2714

Merged
merged 9 commits into from Mar 9, 2022
Merged

Enable smoke test for ARM arch #2714

merged 9 commits into from Mar 9, 2022

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Mar 6, 2022 •
edited

Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es

Note: This PR uses my fork of kind-action because they don't support ARM64 arch yet. Till this PR is not merged, using mine (or another fork at kedacore side) is needed

Note 2: This PR also cleans up some unused imports on e2e tests

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Tests have been added
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Changelog has been updated and is aligned with our changelog requirements

Related #2262

@JorTurFer
Cleanup some tests
6d91255 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Update arm smoke tests script
dc78c8f 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Tmp change for testing
b420268 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Grant execution permissions
dc2b659 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Add smoke test to main and nightly e2e workflow
b2d405e 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Update changelog
e2bd9f8 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer changed the title WIP - Enable smoke test for ARM arch Enable smoke test for ARM arch Mar 7, 2022
@JorTurFer JorTurFer marked this pull request as ready for review March 7, 2022 19:05
@JorTurFer JorTurFer requested a review from a team as a code owner March 7, 2022 19:05
@JorTurFer
Fix style
5ab05a3 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Add missing container on pr validation
e9d368e 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
zroubalik
zroubalik reviewed Mar 8, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Great job

tests/run-arm-smoke-tests.sh Outdated Show resolved Hide resolved
Apply feedback
483284d 
Signed-off-by: Jorge Turrado <jorge.turrado@docplanner.com>
@JorTurFer JorTurFer merged commit 8c85751 into kedacore:main Mar 9, 2022
@JorTurFer JorTurFer deleted the enable-arm-smoke-tests branch March 9, 2022 13:40
RamCohen pushed a commit to RamCohen/keda that referenced this pull request Mar 23, 2022
@RamCohen
Enable smoke test for ARM arch (kedacore#2714)
76c0c5b 
Signed-off-by: Ram Cohen <ram.cohen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JorTurFer @zroubalik