Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests when moving to k8s.io/client-go v0.26.0 #4107

Merged
merged 12 commits into from
Jan 20, 2023

Conversation

dttung2905
Copy link
Contributor

@dttung2905 dttung2905 commented Jan 14, 2023

Hi team,
This is the first PR to resolve #4013. There will be a followed up PR on this issue as this is a relatively big one and I would like to break it down into smaller pieces

A few things I have done:

Checklist

@dttung2905 dttung2905 requested a review from a team as a code owner January 14, 2023 15:48
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
…k_test.go

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
go.mod Outdated Show resolved Hide resolved
@JorTurFer JorTurFer requested a review from a team January 14, 2023 17:41
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
pkg/metricsservice/api/metrics.pb.go Outdated Show resolved Hide resolved
pkg/metricsservice/api/metrics_grpc.pb.go Outdated Show resolved Hide resolved
pkg/scalers/externalscaler/externalscaler.pb.go Outdated Show resolved Hide resolved
pkg/scalers/externalscaler/externalscaler_grpc.pb.go Outdated Show resolved Hide resolved
pkg/scalers/liiklus/LiiklusService.pb.go Outdated Show resolved Hide resolved
pkg/scalers/liiklus/LiiklusService_grpc.pb.go Outdated Show resolved Hide resolved
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

Please also see the failing Static Checks, there are a few suggestions how to modify the code.

…tream()

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
…incompatibility

Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@zroubalik
Copy link
Member

zroubalik commented Jan 19, 2023

/run-e2e
Update: You can check the progress here

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job!

@zroubalik zroubalik merged commit 1c17a5b into kedacore:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace k8s.io/client-go/scale with controller-runtime client
3 participants