-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate old Azure SDKs into to use github.com/Azure/azure-sdk-for-go/sdk/azidentity
#5471
base: main
Are you sure you want to change the base?
Conversation
/run-e2e azure |
/run-e2e azure |
github.com/Azure/azure-sdk-for-go
/run-e2e azure |
/run-e2e azure |
/run-e2e azure |
/run-e2e azure |
/run-e2e azure |
github.com/Azure/azure-sdk-for-go
github.com/Azure/azure-sdk-for-go/sdk/azidentity
/run-e2e azure |
/run-e2e azure |
/run-e2e azure |
96bc418
to
40c04ea
Compare
/run-e2e azure |
/run-e2e azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JorTurFer what is the status on this please?
It's ready to merge from code pov (just pending to rebase main branch). But I think that waiting until v2.14 is released could be a good idea because I'm not 100% sure if I have dropped some AAD-Pod-Identity support and taking into account that v2.15 will remove AAD-Pod-Identity I'm more confident adding this after removing AAD-Pod-Identity. |
Okay, sounds good! |
time to rebase :) |
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
a81a580
to
f39b328
Compare
/run-e2e test-invalid |
/run-e2e azure |
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
/run-e2e test-invalid |
/run-e2e azure |
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
/run-e2e |
/run-e2e github |
This PR has migrated some old Azure SDKs into the (unified) new one
github.com/Azure/azure-event-hubs-go/v3
->github.com/Azure/azure-sdk-for-go/sdk/messaging/azeventhubs
github.com/Azure/azure-storage-blob-go
->github.com/Azure/azure-sdk-for-go/sdk/storage/azblob
github.com/Azure/azure-storage-queue-go
->github.com/Azure/azure-sdk-for-go/sdk/storage/azqueue
github.com/Azure/azure-sdk-for-go
->github.com/Azure/azure-sdk-for-go/sdk/security/keyvault/azsecrets
github.com/Azure/azure-sdk-for-go
->github.com/Azure/azure-sdk-for-go/sdk/monitor/azquery
no-sdk
->github.com/Azure/azure-sdk-for-go/sdk/monitor/azquery
github.com/Azure/azure-kusto-go/kusto
usesgithub.com/Azure/azure-sdk-for-go/sdk/azidentity
Additionally to improve the testing experience, I've replaced
go test ... | junit....
withgotestsum
-> https://github.com/gotestyourself/gotestsumChecklist
Fixes #5470