-
Notifications
You must be signed in to change notification settings - Fork 992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scaledobject): reconcile hpa on label or annotations change #5482
base: main
Are you sure you want to change the base?
fix(scaledobject): reconcile hpa on label or annotations change #5482
Conversation
ee89f8b
to
9c3703e
Compare
Signed-off-by: Grégory SANCHEZ <gregory.sanchez@icloud.com>
9c3703e
to
731512f
Compare
Co-authored-by: Jean-Yves CAMIER <jycamier@gmail.com> Signed-off-by: Grégory SANCHEZ <gregory.sanchez@icloud.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! only a small nit inline.
Although it's okey, I want to know @zroubalik's thoughts because maybe we weren't checking annotations and labels for any reason I'm missing
@@ -132,6 +132,8 @@ func (r *ScaledObjectReconciler) SetupWithManager(mgr ctrl.Manager, options cont | |||
kedacontrollerutil.PausedReplicasPredicate{}, | |||
kedacontrollerutil.ScaleObjectReadyConditionPredicate{}, | |||
predicate.GenerationChangedPredicate{}, | |||
predicate.LabelChangedPredicate{}, | |||
predicate.AnnotationChangedPredicate{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this predicate we don't need
kedacontrollerutil.PausedPredicate{},
kedacontrollerutil.PausedReplicasPredicate{},
as both are allowing changes on annotations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for not reconciling on labels/annotations was to limit the number of reconciliations in total and subsequent re-creation of scale loops. I am not sure we should change the behavior this way. Maybe adding specific fields for annotations/labels in spec.advanced.hpconfig..
? Not sure though
@chubchubsancho Any update on this PR? |
@tomkerkhove sorry i have not so much time past week to rework on this PR. I need to take a look at @zroubalik approach. |
no worries |
Provide a description of what has been changed
HPA need to be reconcile on scaledObject annotations or labels update
Checklist
Fixes #
#5468