fix: Allow ScaledObject.MinReplicaCount to be set to 0 #5571

yorik · 2024-03-04T16:00:36Z

Makes ScaledObject API to be closer to ScaleJob API.
Renames functions to MinReplicaCount and MaxReplicaCount.
Updates doc strings to correspond new names.
Set MinReplicaCount default to 0 as written in the doc:
https://keda.sh/docs/1.5/concepts/scaling-deployments/#overview.
Moves HPA related hacks into hpa.go.

Fixes: #5570.

Makes ScaledObject API to be closer to ScaleJob API. Renames functions to MinReplicaCount and MaxReplicaCount. Updates doc strings to correspond new names. Set MinReplicaCount default to 0 as written in the doc: https://keda.sh/docs/1.5/concepts/scaling-deployments/#overview. Moves HPA related hacks into hpa.go. Fixes: 5570. Signed-off-by: Yury Akudovich <yorik13@gmail.com>

zroubalik · 2024-03-07T09:42:01Z

/run-e2e
Update: You can check the progress here

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

yorik · 2024-03-14T08:43:50Z

I've updated the branch with changes from main and locally those e2e test passed:

Test logs

$ go test -v -tags e2e ./internals/scaling_modifiers/... ./internals/value_metric_type/...
=== RUN   TestScalingModifiers
    scaling_modifiers_test.go:269: -- setting up ---
    helper.go:248: deleting namespace scaling-modifiers-test-ns
    helper.go:301: waiting for namespace scaling-modifiers-test-ns deletion
    helper.go:235: Creating namespace - scaling-modifiers-test-ns
    helper.go:550: Applying template: secretTemplate
    helper.go:550: Applying template: metricsServerDeploymentTemplate
    helper.go:550: Applying template: serviceTemplate
    helper.go:550: Applying template: triggerAuthenticationTemplate
    helper.go:550: Applying template: deploymentTemplate
    helper.go:550: Applying template: workloadDeploymentTemplate
    scaling_modifiers_test.go:281: --- testFormula ---
    helper.go:550: Applying template: soFallbackTemplate
    helper.go:598: Applying template: updateMetricsTemplate
    helper.go:502: Waiting for some time to ensure deployment replica count doesn't change from 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:509: Deployment - scaling-modifiers-test-deployment, Current  - 0
    helper.go:598: Applying template: updateMetricsTemplate
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - depl-workload-base, Current  - 0, Target - 2
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - depl-workload-base, Current  - 2, Target - 2
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - scaling-modifiers-test-deployment, Current  - 1, Target - 3
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - scaling-modifiers-test-deployment, Current  - 3, Target - 3
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - scaling-modifiers-test-deployment, Current  - 3, Target - 5
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - scaling-modifiers-test-deployment, Current  - 1, Target - 5
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - scaling-modifiers-test-deployment, Current  - 5, Target - 5
    helper.go:598: Applying template: updateMetricsTemplate
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - scaling-modifiers-test-deployment, Current  - 5, Target - 2
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - scaling-modifiers-test-deployment, Current  - 2, Target - 2
    helper.go:598: Applying template: updateMetricsTemplate
    helper.go:550: Applying template: soComplexFormula
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - scaling-modifiers-test-deployment, Current  - 2, Target - 0
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - scaling-modifiers-test-deployment, Current  - 0, Target - 0
    helper.go:598: Applying template: updateMetricsTemplate
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - scaling-modifiers-test-deployment, Current  - 0, Target - 3
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - scaling-modifiers-test-deployment, Current  - 3, Target - 3
    helper.go:619: Deleting template: soComplexFormula
    helper.go:619: Deleting template: workloadDeploymentTemplate
    helper.go:619: Deleting template: deploymentTemplate
    helper.go:619: Deleting template: triggerAuthenticationTemplate
    helper.go:619: Deleting template: serviceTemplate
    helper.go:619: Deleting template: metricsServerDeploymentTemplate
    helper.go:619: Deleting template: secretTemplate
    helper.go:248: deleting namespace scaling-modifiers-test-ns
    helper.go:301: waiting for namespace scaling-modifiers-test-ns deletion
    helper.go:301: waiting for namespace scaling-modifiers-test-ns deletion
    helper.go:301: waiting for namespace scaling-modifiers-test-ns deletion
--- PASS: TestScalingModifiers (188.27s)
PASS
ok  	github.com/kedacore/keda/v2/tests/internals/scaling_modifiers
=== RUN   TestScaler
    value_metric_type_test.go:113: --- setting up ---
    helper.go:248: deleting namespace value-metric-type-test-ns
    helper.go:301: waiting for namespace value-metric-type-test-ns deletion
    helper.go:235: Creating namespace - value-metric-type-test-ns
    helper.go:550: Applying template: deploymentTemplate
    helper.go:550: Applying template: monitoredDeploymentTemplate
    value_metric_type_test.go:141: --- testing scale by AverageValue ---
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 8
    helper.go:550: Applying template: scaledObjectTemplate
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 4
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 4, Target - 4
    helper.go:619: Deleting template: scaledObjectTemplate
    value_metric_type_test.go:159: --- testing scale by Value ---
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 4, Target - 8
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 8
    helper.go:550: Applying template: scaledObjectTemplate
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 8, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 9, Target - 10
    helper.go:444: Waiting for deployment replicas to hit target. Deployment - value-metric-type-test-deployment, Current  - 10, Target - 10
    helper.go:619: Deleting template: monitoredDeploymentTemplate
    helper.go:619: Deleting template: deploymentTemplate
    helper.go:248: deleting namespace value-metric-type-test-ns
    helper.go:301: waiting for namespace value-metric-type-test-ns deletion
    helper.go:301: waiting for namespace value-metric-type-test-ns deletion
    helper.go:301: waiting for namespace value-metric-type-test-ns deletion
    helper.go:301: waiting for namespace value-metric-type-test-ns deletion
--- PASS: TestScaler (86.80s)
PASS
ok  	github.com/kedacore/keda/v2/tests/internals/value_metric_type

Could you run e2e tests once again?

SpiritZhou · 2024-03-20T08:50:46Z

/run-e2e
Update: You can check the progress here

SpiritZhou · 2024-03-20T08:52:20Z

Could you also update the ChangeLog.md?

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

yorik · 2024-03-20T13:54:28Z

Could you also update the ChangeLog.md?

Added.

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

yorik · 2024-03-26T12:30:17Z

Are there any chance to merge this? #5570 blocks migration to Keda for us in production.

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

SpiritZhou · 2024-04-15T02:56:37Z

/run-e2e internals
Update: You can check the progress here

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

JorTurFer · 2024-04-28T10:15:55Z

/run-e2e internals
Update: You can check the progress here

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

igor-nikiforov · 2024-05-01T20:18:41Z

Any blockers which prevent this to be merged?

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

yorik · 2024-05-02T14:31:40Z

Any blockers which prevent this to be merged?

I don't see any, but there was some discussion in #5570

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

zroubalik · 2024-05-17T10:06:15Z

/run-e2e internals
Update: You can check the progress here

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

yorik requested a review from a team as a code owner March 4, 2024 16:00

yorik force-pushed the fix-5570 branch from 4611aa7 to 7cf4c6c Compare March 4, 2024 16:02

Merge remote-tracking branch 'upstream/main' into fix-5570

489d9e8

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

727ed55

yorik changed the title ~~fix: Allows ScaledObject.MinReplicaCount to be set to 0.~~ fix: Allow ScaledObject.MinReplicaCount to be set to 0 Mar 20, 2024

Adds CHANGELOG

15a72e5

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

yorik force-pushed the fix-5570 branch from ab80c24 to 15a72e5 Compare March 20, 2024 12:45

Fixes CHANGELOG order

dafc860

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

yorik added 2 commits March 25, 2024 15:17

Merge remote-tracking branch 'upstream/main' into fix-5570

0eddd1d

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

4589080

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

yorik added 8 commits March 26, 2024 18:16

Merge remote-tracking branch 'upstream/main' into fix-5570

34864be

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

75cbc11

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

fd98a30

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

bc56f3d

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

097ac6b

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

fe3d8fd

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

7e60aaa

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

a1a5d30

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

yorik added 4 commits April 16, 2024 12:20

Merge remote-tracking branch 'upstream/main' into fix-5570

50229a2

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

255e688

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

7c71f9b

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

3c2d20e

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

yorik added 7 commits April 24, 2024 09:34

Merge remote-tracking branch 'upstream/main' into fix-5570

1a7e5bf

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

e44c100

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

1a835eb

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

32ce1f8

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

7d6f1ba

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

49195f4

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

5b33604

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

445cba3

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

4a9d950

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

yorik added 6 commits May 7, 2024 09:46

Merge remote-tracking branch 'upstream/main' into fix-5570

81f371d

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

fb0a50c

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

45d0b12

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

02fd2cd

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

7810619

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

76efa11

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

yorik added 4 commits May 21, 2024 13:30

Merge remote-tracking branch 'upstream/main' into fix-5570

c34bb49

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

d76b616

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

96ae74d

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

82e25fc

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

yorik mentioned this pull request May 28, 2024

MinReplicaCount for ScaledObject can't be set to 0 #5570

Open

yorik added 6 commits May 29, 2024 13:20

Merge remote-tracking branch 'upstream/main' into fix-5570

92278d8

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

6ed0d4f

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

ad64169

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

46a8fb1

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

2c9915a

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Merge remote-tracking branch 'upstream/main' into fix-5570

d97529c

Signed-off-by: Yury Akudovich <yorik13@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Allow ScaledObject.MinReplicaCount to be set to 0 #5571

fix: Allow ScaledObject.MinReplicaCount to be set to 0 #5571

yorik commented Mar 4, 2024 •

edited

zroubalik commented Mar 7, 2024 •

edited by github-actions bot

yorik commented Mar 14, 2024 •

edited

SpiritZhou commented Mar 20, 2024 •

edited by github-actions bot

SpiritZhou commented Mar 20, 2024

yorik commented Mar 20, 2024

yorik commented Mar 26, 2024

SpiritZhou commented Apr 15, 2024 •

edited by github-actions bot

JorTurFer commented Apr 28, 2024 •

edited by github-actions bot

igor-nikiforov commented May 1, 2024

yorik commented May 2, 2024

zroubalik commented May 17, 2024 •

edited by github-actions bot

fix: Allow ScaledObject.MinReplicaCount to be set to 0 #5571

Are you sure you want to change the base?

fix: Allow ScaledObject.MinReplicaCount to be set to 0 #5571

Conversation

yorik commented Mar 4, 2024 • edited

zroubalik commented Mar 7, 2024 • edited by github-actions bot

yorik commented Mar 14, 2024 • edited

SpiritZhou commented Mar 20, 2024 • edited by github-actions bot

SpiritZhou commented Mar 20, 2024

yorik commented Mar 20, 2024

yorik commented Mar 26, 2024

SpiritZhou commented Apr 15, 2024 • edited by github-actions bot

JorTurFer commented Apr 28, 2024 • edited by github-actions bot

igor-nikiforov commented May 1, 2024

yorik commented May 2, 2024

zroubalik commented May 17, 2024 • edited by github-actions bot

yorik commented Mar 4, 2024 •

edited

zroubalik commented Mar 7, 2024 •

edited by github-actions bot

yorik commented Mar 14, 2024 •

edited

SpiritZhou commented Mar 20, 2024 •

edited by github-actions bot

SpiritZhou commented Apr 15, 2024 •

edited by github-actions bot

JorTurFer commented Apr 28, 2024 •

edited by github-actions bot

zroubalik commented May 17, 2024 •

edited by github-actions bot