fix:Resolve deprecation warning for klogr.New in Metrics Server #5794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guo Peng <370090914@qq.com>
|
/run-e2e internal |
zroubalik
reviewed
May 17, 2024
Signed-off-by: Guo Peng <370090914@qq.com>
zroubalik
reviewed
May 29, 2024
There was a problem hiding this comment.
Could you please update docs for logs if there are any changes? https://github.com/kedacore/keda/blob/main/BUILD.md#setting-log-levels
| @@ -60,6 +60,9 @@ spec: | |||
| - --logtostderr=true | |||
| - --stderrthreshold=ERROR | |||
| - --v=0 | |||
| - --zap-log-level=info | |||
samsond
reviewed
May 30, 2024
| // | ||
| //nolint:staticcheck // SA1019: klogr.New is deprecated. | ||
| var logger = klogr.New().WithName("keda_metrics_adapter") | ||
| var setupLog = ctrl.Log.WithName("keda_metrics_adapter") |
There was a problem hiding this comment.
I understand that klogr.New is deprecated, but I was wondering if there's a specific reason for introducing setupLog instead of reusing logger variable?
Would it be possible to update the code to consistently use logger without introducing setupLog?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics Server: klogr.New is deprecated use textlogger.NewLogger instead
Checklist
Fixes #5732
Relates to #