Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scaler leak during cache refresh #5807

Merged
merged 2 commits into from
May 20, 2024
Merged

Fix scaler leak during cache refresh #5807

merged 2 commits into from
May 20, 2024

Conversation

gjacquet
Copy link
Contributor

@gjacquet gjacquet commented May 15, 2024 •
edited by zroubalik

Fixes scaler not being properly closed in performGetScalerCache:

  • Fix logic to close scaler when out of date
  • Fix race confition

Checklist

Fixes #5806

@gjacquet
Fix scaler leak during cache refresh
0bc0f80 
Signed-off-by: Guillaume Jacquet <guillaume.jacquet@gmail.com>
@gjacquet gjacquet requested a review from a team as a code owner May 15, 2024 14:35
@zroubalik
Copy link
Member

zroubalik commented May 17, 2024 •
edited by github-actions bot

/run-e2e
Update: You can check the progress here

zroubalik
zroubalik approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thanks a lot for the fix!

@zroubalik
Copy link
Member

@gjacquet can you confirm that this fix helped with the issues in your env?

@gjacquet
Copy link
Contributor Author

@zroubalik Thanks for reviewing!
I have been running this patch in two of our non-production environments and it solved this issue.

@zroubalik
Copy link
Member

Thanks, this is really great fix

@JorTurFer
Copy link
Member

Awesome catch! Thanks for the fix ❤️

@zroubalik zroubalik merged commit d97d2d4 into kedacore:main May 20, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scaler not being properly closed
3 participants
@gjacquet @zroubalik @JorTurFer