adjust to be compatable with depricated numpy syntax (re. shiftnd crash) #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keflavich
requested changes
Apr 4, 2024
|
as requested i have removed the changes to the example notebook |
We don't want the `object` dtype, it breaks the broadcasting rules. Instead, we just want to avoid `np.sum` here.
|
Thanks for the fix. I looked more closely, and to match the intent of the original function, we needed a different set of changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starting from numpy 1.24.0 ragged array are deprecated. previous usage in
shiftndis not compatible any more.see numpy/numpy#22004
Note: perhaps the requirements should be updated to numpy>=1.24.0
closes #55