Add docs for using sort-package-JSON via trunk #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add trunk check instructions
keithamus
requested changes
Dec 14, 2023
There was a problem hiding this comment.
Thanks for the PR and I'm glad you're a big fan!
As is stands this PR takes up a large amount of the README and it seems like it's mostly to promote the trunk check product. I'm happy to see a link inside the # Related tools or ## Supported Libraries subheadings but I think dedicating a whole new section to this seems a little much.
|
Hi Keith. I did it this way to mirror some of the other tools we work with. For example actionlint has a whole section on Tools Integration that shows how to use it with reviewdog, precommit, VS code, and others in addition to Trunk Check. However, if that's not what you want here, how about this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trunk check is an extendible superlinter with a built in language server and prexisting issue detection. sort-package-json is integrated here.
We're big fans of the sort-package-json project and hope our integration can increase its popularity!