Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: error handling on ticks #861

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: error handling on ticks #861

wants to merge 10 commits into from

Commits on Mar 3, 2024

  1. feat: add error handling 

    + added error handling function param on a new constructor
+ added the function param on the static `from` method
+ caught the errors in the callback method
    @JosephVoid @sheerlox
    JosephVoid authored and sheerlox committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    616bb08 View commit details
    Browse the repository at this point in the history

  2. feat: added errorHandler function in CronJobParams

    @JosephVoid @sheerlox
    JosephVoid authored and sheerlox committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    8a24489 View commit details
    Browse the repository at this point in the history

  3. test: added two more test cases 

    + removed `@ts-expect-error line` bc it was throwing error itself
    @JosephVoid @sheerlox
    JosephVoid authored and sheerlox committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    255ce7f View commit details
    Browse the repository at this point in the history

  4. docs: added API description

    @JosephVoid @sheerlox
    JosephVoid authored and sheerlox committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    4417117 View commit details
    Browse the repository at this point in the history

  5. fix: types

    @JosephVoid @sheerlox
    JosephVoid authored and sheerlox committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    1870cdd View commit details
    Browse the repository at this point in the history

  6. test: improve tests

    @JosephVoid @sheerlox
    JosephVoid authored and sheerlox committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    5076e99 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. fix: applied fix based on suggestions 

    + Instead of a new constructor, I added the `errorHandler` on every other constructor
+ removed the superflous if checks
+ added `errorHandler` on every `return new CronJob`
    @JosephVoid @sheerlox
    JosephVoid authored and sheerlox committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    9b2cc1b View commit details
    Browse the repository at this point in the history

  2. fix: moved error handler to BaseCronJobParams

    @JosephVoid @sheerlox
    JosephVoid authored and sheerlox committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    98be5fe View commit details
    Browse the repository at this point in the history

  3. fix: put back the run time exception check

    @JosephVoid @sheerlox
    JosephVoid authored and sheerlox committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    7ae4cca View commit details
    Browse the repository at this point in the history

  4. test: check errorHandler is called with the exception + fix case typo

    @sheerlox
    sheerlox committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    f13aba2 View commit details
    Browse the repository at this point in the history