Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation for Kenji's Twig Library #22

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Installation for Kenji's Twig Library #22

wants to merge 4 commits into from

Conversation

komputronika
Copy link

This additional code is for install CI libraries that depend on other package.
For example: https://github.com/kenjis/codeigniter-ss-twig

The steps are:

  1. Add new package definition to array $this->packages, with a new key 'require'.
  2. Method install will doing additional task: Update composer.json with new requirement and then run composer update.

Test result:

$ ./bin/install.php twig master
Downloaded: https://github.com/kenjis/codeigniter-ss-twig/archive/master.zip
copied: /media/windows/Web/codeigniter-composer-installer-demo/application/libraries/Twig.php
Installing package: CodeIgniter3 Simple and Secure Twig Integration
Loading composer repositories with package information
Updating dependencies (including require-dev)
Nothing to install or update
Generating autoload files
Installed: twig
See https://github.com/kenjis/codeigniter-ss-twig

Thank you.

#21

@kenjis
Copy link
Owner

kenjis commented Sep 17, 2017

@komputronika
Why do you want to use bin/install.php to install Composer pacakges?
You can just run composer command to install Composer pacakges.

@komputronika
Copy link
Author

Hello Kenji,

As I said before. this additional code is for install CI libraries that depend on other package.
For example: https://github.com/kenjis/codeigniter-ss-twig

Yes we can install for example, Twig with composer directly.
But your codeigniter-ss-twig library has wrapped Twig class so easy to use with Codeigniter.
(there is folder libraries inside).

Another example library that depend on other composer package is your codeigniter doctrine library.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants