Skip to content
This repository has been archived by the owner on Jan 6, 2021. It is now read-only.

Commit

Permalink
fix: bin location
Browse files Browse the repository at this point in the history
  • Loading branch information
Kent C. Dodds committed Mar 4, 2017
1 parent dad00c4 commit aae44df
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"description": "Run scripts that set and use environment variables across platforms",
"main": "dist/index.js",
"bin": {
"cross-env": "bin/cross-env.js"
"cross-env": "dist/bin/cross-env.js"
},
"engines": {
"node": ">=4.0"
Expand Down Expand Up @@ -90,4 +90,4 @@
"url": "https://github.com/kentcdodds/cross-env/issues"
},
"homepage": "https://github.com/kentcdodds/cross-env#readme"
}
}

6 comments on commit aae44df

@jankal
Copy link

@jankal jankal commented on aae44df Mar 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of now this breaks JeffreyWay/laravel-mix.
Reported laravel-mix/laravel-mix#521

@kentcdodds
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, actually this commit fixes that. Please update

@jankal
Copy link

@jankal jankal commented on aae44df Mar 4, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kentcdodds How should it with the path hardcoded in https://github.com/laravel/laravel/blob/master/package.json?

@bbashy
Copy link

@bbashy bbashy commented on aae44df Mar 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jankal Looks like it's been updated in laravel/laravel but locally people won't get the update.

@kentcdodds
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see the problem. You should not be relying on the location of the bin file. npm will pre-load the node_modules/.bin directory with all the bins you install and that directory is added to your PATH for your npm scripts. cross-env will not consider file location as part of the public API and therefore you should expect no guarantee that there will not be breaking changes in this regard (that said it's highly unlikely to change from now on).

I will open a PR on that repo to fix this :) <3

@jankal
Copy link

@jankal jankal commented on aae44df Mar 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kentcdodds

Please sign in to comment.