Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: Use jest 27 #210

Merged
merged 3 commits into from
May 27, 2021
Merged

BREAKING CHANGE: Use jest 27 #210

merged 3 commits into from
May 27, 2021

Conversation

eps1lon
Copy link
Contributor

@eps1lon eps1lon commented May 26, 2021

BREAKING CHANGE: Uses jest 27

What:

Use jest 27 (migration guide)

Why:

How:

Bump releated dependencies and fix breaking changes

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@eps1lon
feat: Use jest 27
5fb0824 
BREAKING CHANGE: Now using jest 27.
Check out the migration guide under https://jestjs.io/blog/2021/05/25/jest-27.
@eps1lon eps1lon marked this pull request as ready for review May 26, 2021 07:38
kentcdodds
kentcdodds previously approved these changes May 26, 2021
View reviewed changes
Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 👍

@kentcdodds
Copy link
Owner

Could you configure legacy peer deps in the npmrc to deal with the typeahead issue?

@eps1lon eps1lon mentioned this pull request May 26, 2021
Closed
@eps1lon
Copy link
Contributor Author

eps1lon commented May 26, 2021

Could you configure legacy peer deps in the npmrc to deal with the typeahead issue?

Only checked their source version regarding matching peerDependencies. Considering jest-watch-typeahead only needs to cut a release, I'd wait for a day or two (jest-community/jest-watch-typeahead#61).

@tdeekens tdeekens mentioned this pull request May 26, 2021
Merged
@eps1lon eps1lon requested a review from kentcdodds May 27, 2021 17:05
@eps1lon eps1lon changed the title feat: Use jest 27 BREAKING CHANGE: Use jest 27 May 27, 2021
@codecov
Copy link

codecov bot commented May 27, 2021 •
edited

Codecov Report

Merging #210 (42ccc56) into main (cabb098) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #210   +/-   ##
=======================================
  Coverage   63.29%   63.29%           
=======================================
  Files          21       21           
  Lines         594      594           
  Branches      222      222           
=======================================
  Hits          376      376           
  Misses        177      177           
  Partials       41       41
Impacted Files Coverage Δ
src/config/babel-transform.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cabb098...42ccc56. Read the comment docs.

@kentcdodds kentcdodds merged commit 8118c50 into kentcdodds:main May 27, 2021
@kentcdodds
Copy link
Owner

@all-contributors please add @eps1lon for code

@allcontributors allcontributors bot mentioned this pull request May 27, 2021
Merged
@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @eps1lon! 🎉

@eps1lon eps1lon deleted the feat/jest-27 branch May 27, 2021 21:12
@github-actions
Copy link

🎉 This PR is included in version 10.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MichaelDeBoey
Copy link
Contributor

@kentcdodds Seems like this wasn't released as a new major 🤔

@kentcdodds
Copy link
Owner

Whoops!

kentcdodds added a commit that referenced this pull request May 27, 2021
@kentcdodds
fix(release): manually release a major version
9c0c9f3 
There was an issue with a major release, so this manual-releases.md
change is to release a new major version.

Reference: #210

BREAKING CHANGE: Upgrades kcd-scripts to jest v27
@dodoongtak dodoongtak mentioned this pull request Jun 2, 2021
Closed
@snyk-bot snyk-bot mentioned this pull request Sep 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds Awaiting requested review from kentcdodds

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eps1lon @kentcdodds @MichaelDeBoey