fix: fixed re-record for docker #1876
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
|
@EraKin575 Please fix the build checks ! |
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Sarthak160
reviewed
May 16, 2024
pkg/service/record/utils.go
Outdated
| @@ -54,3 +55,21 @@ func waitForPort(ctx context.Context, host, port string) error { | |||
| } | |||
| } | |||
| } | |||
| func replaceHostToIP(currentURL string, ipAddress string) (string, error) { | |||
There was a problem hiding this comment.
Just move this method in common utils and export
Signed-off-by: EraKin575 <tejaskumar574@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes: #[issue number that will be closed through this PR]
Describe the changes you've made
fixed rerecord with docker
Type of change
Please let us know if any test cases are added
Please describe the tests(if any). Provide instructions how its affecting the coverage.
Describe if there is any unusual behaviour of your code(Write
NAif there isn't)A clear and concise description of it.
Checklist:
Screenshots (if any)