Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Content Overlap on Medium Screen Sizes #35

Closed
wants to merge 0 commits into from

Conversation

Swpn0neel
Copy link

Fixed an issue with the responsiveness of the features section of Keploy's website, where there was a content overlap for the medium screens.

Fixes issue: #1843

Previously, it looked like this:

image

Currently, after fixing, it looks like this:

image

@Hermione2408
Copy link
Member

Hey @Swpn0neel your branch has conflict please resolve it

@Swpn0neel
Copy link
Author

Hey @Swpn0neel your branch has conflict please resolve it

Resolved it!! You can merge it now!!

@Hermione2408
Copy link
Member

Hey @Swpn0neel I am getting compilation error can you please check -

Keploy@0.1.0 build
next build

Failed to compile.

./components/FeatureMoblieView.tsx
Error:
× Unexpected token section. Expected jsx identifier
╭─[/home/hermione/Desktop/work/website/components/FeatureMoblieView.tsx:24:1]
24 │ }, []);
25 │
26 │ return (
27 │


· ───────
28 │ {/* Section background (needs .relative class on parent and next sibling elements) */}
29 │ <div
30 │ className="absolute inset-0 mb-16 pointer-events-none bg-neutral-100"
╰────

Caused by:
Syntax Error

Import trace for requested module:
./components/FeatureMoblieView.tsx
./components/features.tsx

@Swpn0neel
Copy link
Author

I've fixed the issues @Hermione2408. It's now working 👍

@Hermione2408
Copy link
Member

Hey @Swpn0neel Changes looks good to me but there are lot of linting changes can you revert them back

@Swpn0neel
Copy link
Author

Hey @Swpn0neel Changes looks good to me but there are lot of linting changes can you revert them back

There were some grammatical errors which I've found while working with this issue, so I've fixed them... and overall improved the code quality.

@Hermione2408
Copy link
Member

Hey @Swpn0neel Changes looks good to me but there are lot of linting changes can you revert them back

There were some grammatical errors which I've found while working with this issue, so I've fixed them... and overall improved the code quality.

I got your point but still there are linting changes like ' to this " and indentation changes which can cause conflicts in other PR also because of this your exact changes are not identifiable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants