Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

test: PoC to reduce CI pipeline timings #8465

Closed
wants to merge 4 commits into from
Closed

Conversation

RealAnna
Copy link
Contributor

@RealAnna RealAnna commented Jul 19, 2022

Signed-off-by: RealAnna anna.reale@dynatrace.com

This PR

Attempt to reintroduce docker caching
-uses docker/build-push-action#252 (comment)

Caching in between test and prod builds

Research other projects' workflows to see if there are better approaches to docker builds:
dynatrace-operator does test directly on the runner, not in a container...
They also use helm unit testing!
Try to move together builds and unit test runs to decrease wait time in between each step and decrease job count

Related Issues

Closes #8371

Notes

running test outside docker containers using --race showed multiple errors (mostly data races but one of jmeter test needs jmeter installed and thus fails, we should remove it):
https://github.com/keptn/keptn/runs/7428255474?check_suite_focus=true

Follow-up Tasks

Discuss with the team and make a ticket to merge chosen changes

How to test

Here are CI runs with the 3 setups:
reference CI build everything ~ 24m
adding cache to production images ~ 21m (bridge test took 19m test image build 5m 28s)
merging test and build ~19m
adding cache to test images ~17m (bridge test took 15m test image build 4m 36s )

running test directly on the runner (shippy our bottleneck after bridge took ~1m less)
running also bridge tests as git actions ~ 15m 25s (bridge server now 41 s against ~2m while bridge test 12m 47s against 15m !)

Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna RealAnna added the CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE label Jul 19, 2022
@codecov
Copy link

codecov bot commented Jul 19, 2022

Codecov Report

Merging #8465 (66e0d02) into master (f7b8227) will not change coverage.
The diff coverage is n/a.

❗ Current head 66e0d02 differs from pull request most recent head 6a6ed2b. Consider uploading reports for the commit 6a6ed2b to get more accurate results

@@           Coverage Diff           @@
##           master    #8465   +/-   ##
=======================================
  Coverage   66.43%   66.43%           
=======================================
  Files         612      612           
  Lines       32362    32362           
  Branches     1667     1667           
=======================================
  Hits        21499    21499           
  Misses       9566     9566           
  Partials     1297     1297           
Flag Coverage Δ
bridge-server 73.77% <ø> (ø)
bridge2 79.02% <ø> (ø)
cli 43.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: RealAnna <anna.reale@dynatrace.com>
Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@RealAnna RealAnna mentioned this pull request Jul 19, 2022
6 tasks
@RealAnna RealAnna force-pushed the poc/fasten_ci_build branch 3 times, most recently from b0c8a6b to cf08b36 Compare July 20, 2022 15:09
@RealAnna RealAnna changed the title test: build and test in a single step test: PoC to reduce CI pipeline timings Jul 21, 2022
@RealAnna RealAnna mentioned this pull request Jul 21, 2022
6 tasks
Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: try to run test directly

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: try to run test directly

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: try to run test directly

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: try to run test directly

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: try to run test directly

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: add back docker container for bridge

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: try

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: try

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: document all failing test

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: document all failing test

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: document all failing test

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: document all failing test

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: document all failing test

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: document all failing test

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: document all failing test

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: document all failing test

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: document all failing test

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: document all failing test

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: document all failing test

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: document all failing test

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: document all failing test

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: document all failing test

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: document all failing test

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: making build dependant

Signed-off-by: RealAnna <anna.reale@dynatrace.com>

poc: making build dependant

Signed-off-by: RealAnna <anna.reale@dynatrace.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stale
Copy link

stale bot commented Sep 21, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 21, 2022
@stale stale bot closed this Nov 2, 2022
@mowies mowies deleted the poc/fasten_ci_build branch December 12, 2022 09:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI:trigger-build-everything Trigger CI Build: Set BUILD_EVERYTHING=TRUE stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core :: Speed up CI build
1 participant