Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/plugins-hot-reload #1739

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

feat/plugins-hot-reload #1739

wants to merge 9 commits into from

Conversation

brian-mulier-p
Copy link
Member

closes #1671

@brian-mulier-p brian-mulier-p self-assigned this Jul 12, 2023
@brian-mulier-p brian-mulier-p marked this pull request as draft July 12, 2023 08:41
@brian-mulier-p brian-mulier-p marked this pull request as ready for review July 12, 2023 09:39
@brian-mulier-p brian-mulier-p marked this pull request as draft July 12, 2023 09:58
@brian-mulier-p brian-mulier-p force-pushed the feat/plugins-hot-reload branch 3 times, most recently from e6bd58a to 0fc78f9 Compare July 12, 2023 10:18
Skraye
Skraye requested changes Jul 12, 2023
View reviewed changes
Copy link
Member

@Skraye Skraye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well, small changes in the code

core/src/main/java/io/kestra/core/plugins/PluginResolver.java Outdated Show resolved Hide resolved
webserver/src/main/java/io/kestra/webserver/controllers/PluginController.java Outdated Show resolved Hide resolved
Skraye
Skraye approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@Skraye Skraye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loicmathieu
Copy link
Member

@brian-mulier-p just tested it and the cache is not cleaned, the cacheCleaner inside the PluginRegistry is null.

@brian-mulier-p
Copy link
Member Author

I have to test it again but looks strange because if that was the case it would look not working at all 🤔

@loicmathieu
Copy link
Member

@brian-mulier-p just tested again and with the new changes it works.

@brian-mulier-p brian-mulier-p marked this pull request as ready for review August 7, 2023 16:08
@brian-mulier-p brian-mulier-p marked this pull request as draft August 23, 2023 11:31
@brian-mulier-p
Copy link
Member Author

Draft as it needs more work to support runtime hot reload properly updating class loaders

@tchiotludo tchiotludo force-pushed the develop branch 2 times, most recently from d88dc0c to 6699436 Compare December 8, 2023 20:59
@anna-geller anna-geller added this to the v0.16.0 milestone Dec 12, 2023
@tchiotludo tchiotludo force-pushed the develop branch 2 times, most recently from 2dc2842 to ab62ba9 Compare January 21, 2024 10:55
@anna-geller anna-geller modified the milestones: v0.16.0, v0.17.0 Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skraye Skraye Skraye approved these changes

@tchiotludo tchiotludo Awaiting requested review from tchiotludo

@loicmathieu loicmathieu Awaiting requested review from loicmathieu

Assignees

@brian-mulier-p brian-mulier-p

Labels
None yet
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

Plugin Hot Reload
5 participants
@brian-mulier-p @loicmathieu @tchiotludo @Skraye @anna-geller