Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/location by tenant #2589

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Feat/location by tenant #2589

wants to merge 2 commits into from

Conversation

loicmathieu
Copy link
Member

Allow configuring the internal storage at the tenant level.

The local storage has been updated to allow defining a different base path per tenant.

Copy link

sonarcloud bot commented Nov 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

55.6% 55.6% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Member

@brian-mulier-p brian-mulier-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lacks a StorageTestSuite new test to cover that we now allow tenant-specific storage location (will help for other implementations).
Otherwise LGTM

@loicmathieu
Copy link
Member Author

@brian-mulier-p testing it from OSS can be hard because we always return an empty location from OSS and moreover testing that it uses different location is a per-storage validation (different base path, different bucket, ...).

The only thing I can think of is to spy the TenantService to check that it has been correctly called but, honestly, it has no real benefit.

I think this is again something that should be tested at a higher level (as we need to do for the tenant anyway)

@anna-geller
Copy link
Member

this isn't merged yet as it seems we weren't fully aligned on the specific implementation

@loicmathieu perhaps you can close the PR and we can plan a new implementation in 0.15.0? if it is easier to build on top of this PR, maybe we can switch to a draft status?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants