-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/location by tenant #2589
base: develop
Are you sure you want to change the base?
Feat/location by tenant #2589
Conversation
1249a2f
to
86d0fd6
Compare
86d0fd6
to
d14cbd9
Compare
SonarCloud Quality Gate failed. 0 Bugs 55.6% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lacks a StorageTestSuite new test to cover that we now allow tenant-specific storage location (will help for other implementations).
Otherwise LGTM
@brian-mulier-p testing it from OSS can be hard because we always return an empty location from OSS and moreover testing that it uses different location is a per-storage validation (different base path, different bucket, ...). The only thing I can think of is to spy the TenantService to check that it has been correctly called but, honestly, it has no real benefit. I think this is again something that should be tested at a higher level (as we need to do for the tenant anyway) |
this isn't merged yet as it seems we weren't fully aligned on the specific implementation @loicmathieu perhaps you can close the PR and we can plan a new implementation in 0.15.0? if it is easier to build on top of this PR, maybe we can switch to a draft status? |
2dc2842
to
ab62ba9
Compare
febd835
to
51d21c8
Compare
Allow configuring the internal storage at the tenant level.
The local storage has been updated to allow defining a different base path per tenant.