Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): add outputs to WorkingDirectory (#3693) #3711

Merged
merged 2 commits into from
May 14, 2024
Merged

fix(core): add outputs to WorkingDirectory (#3693) #3711

merged 2 commits into from
May 14, 2024

Conversation

fhussonnois
Copy link
Member

Fix: #3693

@fhussonnois fhussonnois force-pushed the fix/gh-3693 branch 5 times, most recently from 09fadb5 to 9f74c91 Compare May 14, 2024 07:35
loicmathieu
loicmathieu approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 remarks but you can merge it anyway if you don't think they are important.

core/src/main/java/io/kestra/core/models/tasks/FlowableTask.java Show resolved Hide resolved
core/src/main/java/io/kestra/core/runners/ExecutorService.java Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check with Ludo if you prefere but if saveFlowableOutput seems to be useless let's remove it (in a separate commit so we can easily add it back)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@fhussonnois fhussonnois merged commit fc07fe5 into develop May 14, 2024
6 checks passed
@fhussonnois fhussonnois deleted the fix/gh-3693 branch May 14, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WorkingDirectory has outputFiles property but it doesn't actually capture outputFiles
2 participants
@fhussonnois @loicmathieu