Skip to content

Commit

Permalink
ci: Re-enable --strict-peer-deps with Node >=17.1
Browse files Browse the repository at this point in the history
Now that Node.js 17.1.0 ships with npm 8.1.2 we can re-enable
--strict-peer-deps (which was fixed in 8.1.1).

Also fix the version in test-secondary to match test-primary.

This reverts commit 5b5ad6a.

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
  • Loading branch information
kevinoid committed Nov 19, 2021
1 parent 14be0de commit 0555f44
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,16 @@ jobs:
#
# TODO: Use 'latest' for most recent (LTS or not) when implemented?
# https://github.com/actions/setup-node/issues/257
node-version: '17'
#
# Require 17.1 or later for npm@>=8.1.1 which fixes --strict-peer-deps
# https://github.com/npm/cli/issues/3868
node-version: '>=17.1'
architecture: x64
check-latest: true
- name: Display Node.js version
run: node --version
- name: Install dependencies
# Note: Not using --strict-peer-deps until npm@8.1.1 ships with Node.js
# due to https://github.com/npm/cli/issues/3868
run: npm install
run: npm install --strict-peer-deps
- name: Lint
run: npm run lint
- name: Run tests
Expand Down Expand Up @@ -91,12 +92,12 @@ jobs:
- windows-latest
node:
- '12.20'
- '*'
- '>=17.1'
exclude:
# Exclude os/version already run in test-primary
- arch: x64
os: ubuntu-latest
node: '*'
node: '>=17.1'
steps:
- uses: actions/checkout@v2
- name: Set up Node.js ${{ matrix.node }}
Expand All @@ -108,9 +109,7 @@ jobs:
- name: Display Node.js version
run: node --version
- name: Install dependencies
# Note: Not using --strict-peer-deps until npm@8.1.1 ships with Node.js
# due to https://github.com/npm/cli/issues/3868
run: npm install
run: npm install --strict-peer-deps
- name: Run tests
run: npm run test-unit-cov
# Note: Not uploading to Codecov, due to poor support for matrix builds
Expand Down

0 comments on commit 0555f44

Please sign in to comment.