Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canonical URLs to all generated pages #459

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

ahus1
Copy link
Contributor

@ahus1 ahus1 commented Apr 11, 2024

Closes #458

@ahus1 ahus1 self-assigned this Apr 11, 2024
Copy link
Contributor

@stianst stianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only minor thing is that ../index.html results in cannonical /index, but should probably be ../?

Closes keycloak#458

Signed-off-by: Alexander Schwartz <aschwart@redhat.com>
@ahus1 ahus1 force-pushed the is-458-add-canonical-urls branch from e0d849e to 5f964e7 Compare April 12, 2024 10:14
@ahus1 ahus1 requested a review from stianst April 12, 2024 10:16
@ahus1
Copy link
Contributor Author

ahus1 commented Apr 12, 2024

@stianst - thank you for spotting this. This is now fixed. Please re-review and merge.

@stianst stianst merged commit 167ae5f into keycloak:main Apr 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pages should have a canonical URL set to allow better Google indexing
2 participants