-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update github action versions #27692
Conversation
6fd7dbb
to
620ba0d
Compare
@stianst - happy to see the upgrade of the upload/download artifact. I tried some time ago and it was unstable then, see #25853 During another attempt in a personal repo, some weeks ago, I also saw problems similar as described in actions/upload-artifact#525. Another thing: The flaky test handler seems to be depending on uploading artifacts the old way, please double-check on that as well. I didn't see any flaky test messages with the new ones. |
Hmm... maybe it would be worth to split this up then, do the simple ones first, and do a follow-up with upload/download-action. Guess the best way to trial the flaky bot stuff is just introduce a flaky test that always fails the first time around. |
9c01ed4
to
b0bbf3b
Compare
b0bbf3b
to
03d788b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unreported flaky test detected, please review
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.model.session.OfflineSessionPersistenceTest#testPersistenceMultipleNodesClientSessionsAtRandomNodeKeycloak CI - Store Model Tests
|
Signed-off-by: stianst <stianst@gmail.com>
03d788b
to
901ccc1
Compare
Signed-off-by: stianst <stianst@gmail.com>
No description provided.