Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github action versions #27692

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

stianst
Copy link
Contributor

@stianst stianst commented Mar 8, 2024

No description provided.

@stianst stianst requested a review from a team as a code owner March 8, 2024 04:35
@ahus1
Copy link
Contributor

ahus1 commented Mar 8, 2024

@stianst - happy to see the upgrade of the upload/download artifact. I tried some time ago and it was unstable then, see #25853

During another attempt in a personal repo, some weeks ago, I also saw problems similar as described in actions/upload-artifact#525.

Another thing: The flaky test handler seems to be depending on uploading artifacts the old way, please double-check on that as well. I didn't see any flaky test messages with the new ones.

@stianst
Copy link
Contributor Author

stianst commented Mar 13, 2024

@stianst - happy to see the upgrade of the upload/download artifact. I tried some time ago and it was unstable then, see #25853

During another attempt in a personal repo, some weeks ago, I also saw problems similar as described in actions/upload-artifact#525.

Another thing: The flaky test handler seems to be depending on uploading artifacts the old way, please double-check on that as well. I didn't see any flaky test messages with the new ones.

Hmm... maybe it would be worth to split this up then, do the simple ones first, and do a follow-up with upload/download-action. Guess the best way to trial the flaky bot stuff is just introduce a flaky test that always fails the first time around.

Copy link

@keycloak-github-bot keycloak-github-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.session.OfflineSessionPersistenceTest#testPersistenceMultipleNodesClientSessionsAtRandomNode

Keycloak CI - Store Model Tests

java.lang.AssertionError: 
threads didn't terminate in time: [main (TIMED_WAITING): locked on java.util.concurrent.FutureTask@3a441d42 waiting for 93453 ms blocked for 0 ms
	at java.base@17.0.10/jdk.internal.misc.Unsafe.park(Native Method)
	at java.base@17.0.10/java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:252)
	at java.base@17.0.10/java.util.concurrent.FutureTask.awaitDone(FutureTask.java:444)
...

Report flaky test

Signed-off-by: stianst <stianst@gmail.com>
@ahus1 ahus1 merged commit 2672b36 into keycloak:main Mar 22, 2024
73 checks passed
ahus1 pushed a commit to ahus1/keycloak that referenced this pull request Mar 22, 2024
Signed-off-by: stianst <stianst@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants