#29266 Improve documentation on ClientRolemappingsRessource #29344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Thanks @sprehn-ero , it does look good to me. Can you please sign-off your commit (see https://github.com/keycloak/keycloak/blob/main/CONTRIBUTING.md#developers-certificate-of-origin) and also edit the commit message with a reference to the original issue (Closes #29266) |
Closes keycloak#29266 Signed-off-by: Sebastian Prehn <sebastian.prehn@ero.eu>
sprehn-ero
force-pushed
the
bugfix/29266-admin-rest-api-documentation
branch
from
dbd2fa4
to
53b25ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will apply the requested changes in admin rest api documentation.
ClientRole Mappings can be applied to both users and groups.
More specific naming and description on Parameter client-id.
POST /admin/realms/{realm}/groups/{group-id}/role-mappings/clients/{client}
I did not find a fix to specify the body argument RoleRepresentation -> List[RoleRepresentation].
The type of this parameter is List, so the description should be automatically applied by the framework.