Allow migration of non-persistent sessions to persistent sessions

[ahus1]

Closes #29375

[ahus1]

@mhajas - this is still missing a test. I'd be happy for your feedback if this goes into the right direction. Thanks!

[thomasdarimont]

This will be quite useful to have!
For environments with many sessions (1-10 million) the migration might take a while. In this case it would also be helpful to let users know how many sessions will be migrated, in order to estimate the overall duration of the migration.
How about adding a log message when the migration starts, with the information how many sessions are going to be migrated?

[ahus1]

In this case it would also be helpful to let users know how many sessions will be migrated, in order to estimate the overall duration of the migration.

@thomasdarimont - thank you for the suggestion. I think this would be a good follow-up PR. I will need some advice on how to use the estimate counting to avoid an expensive operation.

I added it as an optional task to #28265

[ahus1]

@mhajas / @pruivo - I'd think this is now ready for a final review, a test exists and it is green.

I know that we have #29592 pending, but maybe we can squash-merge this one first and then tackle the last one.

[ahus1]

@ryanemerson - I've updated the docs, please re-review. Thanks!

[keycloak-github-bot]

Unreported flaky test detected, please review

[keycloak-github-bot]

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.session.UserSessionPersisterProviderTest#testMigrateSession

Keycloak CI - Store Model Tests

java.lang.AssertionError: expected:<3> but was:<0>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
...

Report flaky test

[keycloak-github-bot]

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.session.UserSessionPersisterProviderTest#testMigrateSession

Keycloak CI - Store Model Tests

java.lang.AssertionError: expected:<3> but was:<1>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
...

Report flaky test

org.keycloak.testsuite.model.session.SessionTimeoutsTest#testOfflineUserClientIdleTimeoutSmallerThanSessionNoRefresh

Keycloak CI - Store Model Tests

java.lang.AssertionError: expected null, but was:<org.keycloak.models.sessions.infinispan.AuthenticatedClientSessionAdapter@44bbe1d1>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotNull(Assert.java:756)
	at org.junit.Assert.assertNull(Assert.java:738)
	at org.junit.Assert.assertNull(Assert.java:748)
...

Report flaky test

[keycloak-github-bot]

Unreported flaky test detected, please review

[ahus1]

@dbubenheim - we're currently working on persistent sessions, see discussion #28271 over there. Given our previous discussion, I assume you might be interested in that feature as it IMHO has the potential to simplify your current setup.

I'd hope we get this change into main before KC25 is released. KC25 is currently scheduled for end of May, and I wonder if you would be interested and have the time to test this migration with your setup before or after our release.

[mhajas]

Thank you @ahus1! This is a great addition for people that use some sort of persistence in their current setup