Change the default role mapping filter to clients #29405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamstah
force-pushed
the
role-mapping-default-clients
branch
9 times, most recently
from
dde1547
to
42031d9
Compare
Client roles are more common that realm roles, so we should start the user off looking at a more useful set of options. Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
Jamstah
force-pushed
the
role-mapping-default-clients
branch
from
42031d9
to
163ff52
Compare
|
@xianli123 @edewit I finally got the tests to pass after realising that #29423 was causing my E2E failures. Just luck that this last run wasn't affected I think. |
edewit
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client roles are more common that realm roles, so we should start the user off looking at a more useful set of options.
Closes #29348