Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(common): establish test_color.cpp #10426

Closed
mcdurdin opened this issue Jan 18, 2024 · 0 comments · Fixed by #11483
Closed

chore(common): establish test_color.cpp #10426

mcdurdin opened this issue Jan 18, 2024 · 0 comments · Fixed by #11483
Assignees
@mcdurdin
Labels
chore common/
Milestone
A18S2

Comments

@mcdurdin
Copy link
Member

mcdurdin commented Jan 18, 2024 •
edited

in test_color.h we have a non-extern var defn which is a bad thing to do:

bool enabled = false;   // TODO: move to test_color.c because test_color.h cannot be #included in more than 1 file in a project otherwise.

Spotted in #10403.
@mcdurdin mcdurdin added this to the B17S1 milestone Jan 18, 2024
@mcdurdin mcdurdin self-assigned this Jan 18, 2024
@mcdurdin mcdurdin modified the milestones: B17S1, 18.0 Feb 6, 2024
@mcdurdin mcdurdin modified the milestones: 18.0, A18S1 Apr 19, 2024
@darcywong00 darcywong00 modified the milestones: A18S1, A18S2 May 11, 2024
mcdurdin added a commit that referenced this issue May 20, 2024
@mcdurdin
refactor(common): move enabled declaration into test_color.cpp
9465c3e 
Moves variable declaration for `bool enabled` from .h to .cpp and fixes
up builds. Fixes `#include` in ldml_test_source.cpp which was inside a
namespace.

Fixes: #10426
@mcdurdin mcdurdin mentioned this issue May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcdurdin mcdurdin

Labels
chore common/
Milestone
A18S2
Development

Successfully merging a pull request may close this issue.

refactor(common): move enabled declaration into test_color.cpp keymanapp/keyman
2 participants
@mcdurdin @darcywong00