Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(common): move enabled declaration into test_color.cpp #11483

Merged
merged 2 commits into from
May 21, 2024

Conversation

mcdurdin
Copy link
Member

Moves variable declaration for bool enabled from .h to .cpp and fixes up builds. Fixes #include in ldml_test_source.cpp which was inside a namespace.

Fixes: #10426

@keymanapp-test-bot skip

Moves variable declaration for `bool enabled` from .h to .cpp and fixes
up builds. Fixes `#include` in ldml_test_source.cpp which was inside a
namespace.

Fixes: #10426
@mcdurdin mcdurdin requested a review from rc-swag as a code owner May 20, 2024 08:44
@keymanapp-test-bot keymanapp-test-bot bot added this to the A18S2 milestone May 20, 2024
Copy link
Contributor

@darcywong00 darcywong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcdurdin mcdurdin merged commit 8d6a3de into master May 21, 2024
17 checks passed
@mcdurdin mcdurdin deleted the refactor/common/10426-test_color.cpp branch May 21, 2024 04:35
@keyman-server
Copy link
Collaborator

Changes in this pull request will be available for download in Keyman version 18.0.40-alpha

srl295 added a commit that referenced this pull request May 23, 2024
- incorporate change from #11483

Fixes: #10183
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

chore(common): establish test_color.cpp
3 participants