-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): custom infrastructure for @web/test-runner use 🏃 #11403
Conversation
…est-runner launcher fails
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
@@ -94,7 +94,7 @@ function test-headless() { | |||
TEST_OPTS="--reporter mocha-teamcity-reporter" | |||
fi | |||
if [[ -n "$TEST_EXTENSIONS" ]]; then | |||
TEST_OPTS=" --extension $TEST_EXTENSIONS" | |||
TEST_OPTS="$TEST_OPTS --extension $TEST_EXTENSIONS" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I happened to notice that Web's child build scripts weren't outputting their headless-testing results into TC-friendly format even when run by CI. It was a simple fix, and it's kind of related anyway, so I threw the one-liner fix in here.
From the latest build of #11404: Here's confirmation that the custom TC-reporter functions as intended. |
…nd; also adds polish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, assuming that TODO does not need to be addressed first
Changes in this pull request will be available for download in Keyman version 18.0.41-alpha |
Try as I might, I couldn't find any reporters for @web/test-runner designed for use with TeamCity. Fortunately, they've got pretty good documentation for their reporter API... so I decided to roll our own. As work went on and I remembered some issues we've had with browser-level automated tests in the past, I also added a couple more features to enhance our build logs and surface data that wasn't easily accessible otherwise.
Obviously, I worked on these after actually migrating many of our automated tests to @web/test-runner. That said... it'd be simpler and more time-efficient to review such PRs with the changes near-finalized out of the gate, so I've hoisted this earlier in the commit chain.
So, the new modules:
Also, rather than require pre-compilation... I just used JSDoc comments to achieve pseudo-TypeScript. That can be changed if desired easily enough. I'm also not sure this is the best place to leave the definitions, so I'd like to address concerns on code location and the JS/TS question at the same time. As it is, this implementation is enough to proceed with further work, so I decided to move on to questions with clearer answers.
See related CI build logs for #11404 (Test - Language Modeling Layer) to inspect and verify the output and usefulness of these reporters.
@keymanapp-test-bot skip