-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web): conversion of Web's browser-integration auto-tests for @web/test-runner use 🏃 #11455
Conversation
…r 'dom' integration tests
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the test file that hops from web/src/test/auto/integrated into web/src/test/auto/dom.
function get_default_browser_set() { | ||
if [[ $BUILDER_OS == mac ]]; then | ||
BROWSERS="--browsers Firefox,Chrome,Safari" | ||
elif [[ $BUILDER_OS == win ]]; then | ||
BROWSERS="--browsers Firefox,Chrome" | ||
else | ||
BROWSERS="--browsers Firefox,Chrome" | ||
fi | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source of the current build failure:
./test.sh: line 80: get_default_browser_set: command not found
Looks like I rebased this deletion a bit too early, so the CI check for this PR falls over here. It's fine as of the next PR in the chain though - #11456 passed its checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: /web/build.sh was not adjusted to include install playwright
as part of its configure.
Reasons:
- It currently doesn't have its own
configure
action - it has child projects for that. - It and its child projects (
engine/osk
) have dependencies on projects that do haveconfigure
actions that'll run it anyway.
Changes in this pull request will be available for download in Keyman version 18.0.42-alpha |
Also known as web/src/test/dom, since that's its current name.
All the fixture work related to these tests makes for quite a number of changed lines, but fortunately there are pretty strong patterns throughout.
Also of note: I moved one of the tests from the "end to end" style tests into this section, as it's all about "wrapping" specific types of context-supporting elements with our
OutputTarget
abstraction. Now that we have a better setup for running these against all main browser engines, that set of tests fits better here.@keymanapp-test-bot skip