-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web): removes unused locals, imports, and private fields 馃敥 #11460
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
Can you include a reference for why this is being done? (It's part of a larger task, right?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this PR, lots of snippets of junk code cleaned up 馃榿
common/web/gesture-recognizer/src/test/auto/headless/gesturePath.spec.ts
Outdated
Show resolved
Hide resolved
common/web/gesture-recognizer/src/test/auto/headless/gesturePath.spec.ts
Outdated
Show resolved
Hide resolved
eef8c32
to
a5c10e8
Compare
4e2ab0c
to
cd3e4ea
Compare
93b0121
to
82db2c6
Compare
82db2c6
to
50a194a
Compare
Changes in this pull request will be available for download in Keyman version 18.0.45-alpha |
3 similar comments
Changes in this pull request will be available for download in Keyman version 18.0.45-alpha |
Changes in this pull request will be available for download in Keyman version 18.0.45-alpha |
Changes in this pull request will be available for download in Keyman version 18.0.45-alpha |
Addresses part of #11473, correcting all errors and warnings that resulted when enforcing
"noUnusedLocals"
across all Keyman Engine for Web related code.@keymanapp-test-bot skip