chore(web): enforce strict function types in web/ 🔩 #11463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
|
Can you include a reference for why this is being done? |
mcdurdin
approved these changes
May 17, 2024
jahorton
force-pushed
the
chore/web/remove-no-implicit-any
branch
from
6209a4f
to
4e80e63
Compare
jahorton
force-pushed
the
chore/web/strict-func-types
branch
from
af8cb63
to
a94c511
Compare
jahorton
changed the title
…e/web/strict-func-types
jahorton
changed the title
|
Changes in this pull request will be available for download in Keyman version 18.0.47-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like enforcing this setting hinders more than it helps in web/ - the lack of strictness was very useful being able to typecast within a listener's parameter listing. That gets disabled here. Granted, some of this was required from previous config-setting PRs, but here, it feels like the majority of the changes.
Either way, it's part of #11473, so here we are.
@keymanapp-test-bot skip