-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(web): finalize web/ project parity with base-repo TS config settings (aside from JS version target) 🔩 #11464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User Test ResultsTest specification and instructions
Test Artifacts
|
Can you include a reference for why this is being done? |
mcdurdin
approved these changes
May 17, 2024
ermshiperete
approved these changes
May 22, 2024
This was referenced May 23, 2024
keymanapp-test-bot
bot
added
has-user-test
user-test-required
User tests have not been completed
labels
May 23, 2024
Test Results
|
keymanapp-test-bot
bot
removed
the
user-test-required
User tests have not been completed
label
May 23, 2024
jahorton
force-pushed
the
chore/web/strict-func-types
branch
from
May 29, 2024 03:46
af8cb63
to
a94c511
Compare
jahorton
force-pushed
the
chore/web/final-config-flag-fixes
branch
from
May 29, 2024 03:59
62fa316
to
70c7268
Compare
jahorton
changed the title
chore(web): finalizes web/ project parity with base-repo TS config settings (aside from JS version target)
chore(web): finalizes web/ project parity with base-repo TS config settings (aside from JS version target) 🔩
May 29, 2024
It should've been fixed previously, but maybe I messed things up with this while rebasing?
jahorton
changed the title
chore(web): finalizes web/ project parity with base-repo TS config settings (aside from JS version target) 🔩
chore(web): finalize web/ project parity with base-repo TS config settings (aside from JS version target) 🔩
Jun 3, 2024
Changes in this pull request will be available for download in Keyman version 18.0.47-alpha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, I expected these final flags to be worse than enforcing
strictFunctionTypes
. Maybe it's due to some of the changes the previous setting triggered, but this part went quite swimmingly.Fixes #11473.
User Testing
TEST_DEVELOPER_KMC: Using the test build of Keyman Developer, verify that keyboard compilation works properly.
./build.sh clean
.ekwtamil99uni
(at https://github.com/keymanapp/keyboards/tree/master/release/e/ekwtamil99uni).ekwtamil99uni.kmn
> Build > Compile Keyboard and verify that no errors are emitted.ekwtamil99uni.kps
> Build > Compile Package and verify that no errors are emitted.TEST_DEVELOPER_SERVER: Using the test build of Keyman Developer, verify that the Web test-host page works properly for testing Web keyboards.
ekwtamil99uni
(at https://github.com/keymanapp/keyboards/tree/master/release/e/ekwtamil99uni).ekwtamil99uni.kmn
> Build > Compile Keyboard and verify that no errors are emitted.