(fix) deleteing files from the fs or fs adapters was broken, and now is not #4513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njs50
force-pushed
the
feature/fix-delete-fs
branch
from
b7e36f7
to
2a86790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting
autoCleanup === trueforTypes.Filethe admin would error, and files would not be correctly removed from the relevant file system. I tried this against the Azure adapter and the built in FS adapter.This PR fixes those issues, and seems to work for both adapters fine.
No tests were broken during the course of this change.
@wmertens @jossmac @JedWatson