Skip to content

Commit

Permalink
pages.goto should be awaited (#6053)
Browse files Browse the repository at this point in the history
  • Loading branch information
gwyneplaine committed Jul 5, 2021
1 parent aa91fda commit 058137a
Show file tree
Hide file tree
Showing 13 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion tests/examples-smoke-tests/auth.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exampleProjectTests('../examples-staging/auth', browserType => {
beforeAll(async () => {
browser = await browserType.launch();
page = await browser.newPage();
page.goto('http://localhost:3000');
await page.goto('http://localhost:3000');
});
initFirstItemTest(() => page);
afterAll(async () => {
Expand Down
2 changes: 1 addition & 1 deletion tests/examples-smoke-tests/basic.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ exampleProjectTests('../examples-staging/basic', browserType => {
beforeAll(async () => {
browser = await browserType.launch();
page = await browser.newPage();
page.goto('http://localhost:3000');
await page.goto('http://localhost:3000');
});
initFirstItemTest(() => page);
test('sign out and sign in', async () => {
Expand Down
2 changes: 1 addition & 1 deletion tests/examples-smoke-tests/blog.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exampleProjectTests('blog', browserType => {
beforeAll(async () => {
browser = await browserType.launch();
page = await browser.newPage();
page.goto('http://localhost:3000');
await page.goto('http://localhost:3000');
});
test('Load list', async () => {
await Promise.all([page.waitForNavigation(), page.click('h3:has-text("Authors")')]);
Expand Down
2 changes: 1 addition & 1 deletion tests/examples-smoke-tests/default-values.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exampleProjectTests('default-values', browserType => {
beforeAll(async () => {
browser = await browserType.launch();
page = await browser.newPage();
page.goto('http://localhost:3000');
await page.goto('http://localhost:3000');
});
test('Load list', async () => {
await Promise.all([page.waitForNavigation(), page.click('h3:has-text("People")')]);
Expand Down
2 changes: 1 addition & 1 deletion tests/examples-smoke-tests/document-field.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exampleProjectTests('document-field', browserType => {
beforeAll(async () => {
browser = await browserType.launch();
page = await browser.newPage();
page.goto('http://localhost:3000');
await page.goto('http://localhost:3000');
});
test('Load list', async () => {
await Promise.all([page.waitForNavigation(), page.click('h3:has-text("Authors")')]);
Expand Down
2 changes: 1 addition & 1 deletion tests/examples-smoke-tests/ecommerce.test.disabled.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ exampleProjectTests('ecommerce', browserType => {
beforeAll(async () => {
browser = await browserType.launch();
page = await browser.newPage();
page.goto('http://localhost:3000');
await page.goto('http://localhost:3000');
});
initFirstItemTest(() => page);
afterAll(async () => {
Expand Down
2 changes: 1 addition & 1 deletion tests/examples-smoke-tests/extend-graphql-schema.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exampleProjectTests('extend-graphql-schema', browserType => {
beforeAll(async () => {
browser = await browserType.launch();
page = await browser.newPage();
page.goto('http://localhost:3000');
await page.goto('http://localhost:3000');
});
test('Load list', async () => {
await Promise.all([page.waitForNavigation(), page.click('h3:has-text("Authors")')]);
Expand Down
2 changes: 1 addition & 1 deletion tests/examples-smoke-tests/json.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exampleProjectTests('json', browserType => {
beforeAll(async () => {
browser = await browserType.launch();
page = await browser.newPage();
page.goto('http://localhost:3000');
await page.goto('http://localhost:3000');
});
test('Load list', async () => {
await Promise.all([page.waitForNavigation(), page.click('h3:has-text("People")')]);
Expand Down
2 changes: 1 addition & 1 deletion tests/examples-smoke-tests/roles.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exampleProjectTests('../examples-staging/roles', browserType => {
beforeAll(async () => {
browser = await browserType.launch();
page = await browser.newPage();
page.goto('http://localhost:3000');
await page.goto('http://localhost:3000');
});
initFirstItemTest(() => page);
afterAll(async () => {
Expand Down
2 changes: 1 addition & 1 deletion tests/examples-smoke-tests/task-manager.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exampleProjectTests('task-manager', browserType => {
beforeAll(async () => {
browser = await browserType.launch();
page = await browser.newPage();
page.goto('http://localhost:3000');
await page.goto('http://localhost:3000');
});
test('Load list', async () => {
await Promise.all([page.waitForNavigation(), page.click('h3:has-text("People")')]);
Expand Down
2 changes: 1 addition & 1 deletion tests/examples-smoke-tests/testing.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exampleProjectTests('testing', browserType => {
beforeAll(async () => {
browser = await browserType.launch();
page = await browser.newPage();
page.goto('http://localhost:3000');
await page.goto('http://localhost:3000');
});
initFirstItemTest(() => page);
afterAll(async () => {
Expand Down
2 changes: 1 addition & 1 deletion tests/examples-smoke-tests/virtual-field.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exampleProjectTests('virtual-field', browserType => {
beforeAll(async () => {
browser = await browserType.launch();
page = await browser.newPage();
page.goto('http://localhost:3000');
await page.goto('http://localhost:3000');
});
test('Load list', async () => {
await Promise.all([page.waitForNavigation(), page.click('h3:has-text("Authors")')]);
Expand Down
2 changes: 1 addition & 1 deletion tests/examples-smoke-tests/with-auth.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ exampleProjectTests('with-auth', browserType => {
beforeAll(async () => {
browser = await browserType.launch();
page = await browser.newPage();
page.goto('http://localhost:3000');
await page.goto('http://localhost:3000');
});
initFirstItemTest(() => page);
afterAll(async () => {
Expand Down

1 comment on commit 058137a

@vercel
Copy link

@vercel vercel bot commented on 058137a Jul 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.