Repair the issue with file uploads in the Emacs client. #735
+55
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for these PRs to improve the Emacs experience, @yuzhou721 ! We'll get them tested on our end this week. |
debanjum
reviewed
May 19, 2024
There was a problem hiding this comment.
Hey @yuzhou721, the PR looks neatly done! I've left a few minor comments and I'll repro+test the fix out in a day or two.
added 2 commits
May 27, 2024 10:42
|
I think You should work on UI and Ux Experience that it. |
|
For example, display some upload status in the mode-line? |
|
Is there any issue with this PR? Can it be merged now? |
No issues at all! Just wanted to test it out but was a little swamped with other work. Let me have a look at it right now. |
|
Hey @yuzhou721, Thanks for your patience. I've verified functionality, changes look good! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to batch upload.
Resolves #726