Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow building on recent nightlies #872

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Aug 27, 2023

The proc-macro2 package is old and it is not possible to compile it with a recent nightly compiler

dtolnay/proc-macro2#356
rust-lang/rust#113152

@epage
Copy link
Collaborator

epage commented Aug 28, 2023

The title says "fix" but nothing says what is intended to be fixed. What is the goal with this PR?

@aminya
Copy link
Contributor Author

aminya commented Aug 28, 2023

@epage the proc-macro2 package is so old, it was not possible to compile it with a nightly compiler. This fixes the issue.

@epage epage changed the title fix: update dependencies fix: Allow building on recent nightlies Aug 28, 2023
@epage
Copy link
Collaborator

epage commented Aug 28, 2023

Thanks!

I've updated the title and description. Please share this kind of information in the future.

@epage epage merged commit 2974789 into killercup:master Aug 28, 2023
11 checks passed
@aminya
Copy link
Contributor Author

aminya commented Aug 28, 2023

You're welcome. I linked the issues for more context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants