Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New System Configuration for Timesheet's description field optional or mandatory. #4840

Closed
wants to merge 3 commits into from

Conversation

adambarath
Copy link

Description

Add opportunity users to make timesheet's description field mandatory.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai (see license)

@CLAassistant
Copy link

CLAassistant commented May 6, 2024

CLA assistant check
All committers have signed the CLA.

@kevinpapst
Copy link
Member

Thank you. The problem with this approach is: you cannot enforce it. People can simply click "restart" (or use the calendar or the weekly hours) and it won't work.

See https://www.kimai.org/documentation/plugin-custom-content.html#javascript

Bildschirmfoto 2024-05-06 um 14 37 26

@kevinpapst
Copy link
Member

Thanks for taking the time to share that code.
Your approach has a few issues that make it incompatible with the core.
So I am not going to merge that.

But: you can write a small plugin that adds this feature via a global form listener.
Or you simply use the shared javascript code.

@kevinpapst kevinpapst closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants