Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Util.php #4853

Closed
wants to merge 1 commit into from
Closed

Update Util.php #4853

wants to merge 1 commit into from

Conversation

habibhaidari1
Copy link
Contributor

Proposal to fix rate rounding issues on invoices. Since the invoices show the duration as a decimal number with two decimal points.

Example:
assuming that the hourly rate is 34.34 and the duration is 25 minutes Current algorithm calculates 1500/3600*34.34 = 14.31 € proposal algorithm calculates 0.42 (number on the invoice) * 34.34 = 14.42 €

It's dirty but works for me. I don't expect that to be part of the repo

Description

A clear and concise description of what this pull request adds or changes.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai (see license)

Proposal to fix rate rounding issues on invoices. Since the invoices show the duration as a decimal number with two decimal points.

Example: 
assuming that the hourly rate is 34.34 and the duration is 25 minutes
Current algorithm calculates 1500/3600*34.34 = 14.31 €
proposal algorithm calculates 0.42 (number on the invoice) * 34.34 = 14.42 €

It's dirty but works for me. I don't expect that to be part of the repo
@CLAassistant
Copy link

CLAassistant commented May 13, 2024

CLA assistant check
All committers have signed the CLA.

@kevinpapst
Copy link
Member

Thank you 👍

I will work on the invoices in the near future and then come back to this topic here.

@habibhaidari1 habibhaidari1 closed this by deleting the head repository May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants