Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stop multiarch images being lost on re tagging docker images #4856

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tobybatch
Copy link
Member

Description

When we re-tag docker images we loose the arm64 versions of the multi arch

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai (see license)

@CLAassistant
Copy link

CLAassistant commented May 14, 2024

CLA assistant check
All committers have signed the CLA.

@tobybatch
Copy link
Member Author

@Not-Code do you see a draw back over this? It's a stack overflow fix, I've not used it before.

https://stackoverflow.com/questions/71470604/re-tagging-multi-arch-docker-image

@kevinpapst
Copy link
Member

Probably not the right place, but have you seen that the base images built in about 18 minutes? So far less problematic than the expected two hours: https://github.com/kimai/kimai/actions/workflows/docker-base.yaml

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.78%. Comparing base (e042ef6) to head (a6f9700).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4856   +/-   ##
=========================================
  Coverage     87.77%   87.78%           
  Complexity     8963     8963           
=========================================
  Files           797      797           
  Lines         29414    29414           
=========================================
+ Hits          25819    25820    +1     
+ Misses         3595     3594    -1     

see 2 files with indirect coverage changes

@tobybatch
Copy link
Member Author

@kevinpapst I'll build an all in one workflow that we can test for timing. I'm looking at caching in builds at work ATM as well.

Copy link
Member

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never used any of those actions 🤷 ... so 👍 😁

The only things that jump in my eyes are:

  • we have a lot of redundant tags
  • why do we install Install buildx in the step before at line 22 if we don't use it afterwards?

@kevinpapst
Copy link
Member

Is this ready? Having the arm64 version would be great actually and I want to create a new release.

Does this superseed #4592 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants