-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: stop multiarch images being lost on re tagging docker images #4856
base: main
Are you sure you want to change the base?
Conversation
@Not-Code do you see a draw back over this? It's a stack overflow fix, I've not used it before. https://stackoverflow.com/questions/71470604/re-tagging-multi-arch-docker-image |
Probably not the right place, but have you seen that the base images built in about 18 minutes? So far less problematic than the expected two hours: https://github.com/kimai/kimai/actions/workflows/docker-base.yaml |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4856 +/- ##
=========================================
Coverage 87.77% 87.78%
Complexity 8963 8963
=========================================
Files 797 797
Lines 29414 29414
=========================================
+ Hits 25819 25820 +1
+ Misses 3595 3594 -1 |
@kevinpapst I'll build an all in one workflow that we can test for timing. I'm looking at caching in builds at work ATM as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never used any of those actions 🤷 ... so 👍 😁
The only things that jump in my eyes are:
- we have a lot of redundant tags
- why do we install Install buildx in the step before at line 22 if we don't use it afterwards?
Is this ready? Having the arm64 version would be great actually and I want to create a new release. Does this superseed #4592 ? |
Description
When we re-tag docker images we loose the arm64 versions of the multi arch
Types of changes
Checklist
composer code-check
)