Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update note about using with ember-cli-sass #64

Merged
merged 1 commit into from Apr 5, 2021

Conversation

nag5000
Copy link
Contributor

@nag5000 nag5000 commented Apr 4, 2021

If dart-sass is used (which is the default Sass implementation in ember-cli-sass 9+), sourceMapEmbed: true will not work without sourceMap: true (if sourceMap is not true, the sourcemaps will not be generated regardless of sourceMapEmbed or sourceMapContents).

https://github.com/sass/dart-sass/blob/3d39f22cbff8097c212dd90a507c22dd808c3f19/lib/src/node.dart#L343-L387

If dart-sass is used (which is the default Sass implementation in ember-cli-sass 9+), `sourceMapEmbed: true` will not work without `sourceMap: true` (if `sourceMap` is not true, the sourcemaps will not be generated regardless of `sourceMapEmbed` or `sourceMapContents`).

https://github.com/sass/dart-sass/blob/3d39f22cbff8097c212dd90a507c22dd808c3f19/lib/src/node.dart#L343-L387
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snewcomer snewcomer merged commit b0140ca into kimroen:master Apr 5, 2021
@nag5000 nag5000 deleted the patch-1 branch April 5, 2021 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants