Update: ember addon ember-cli-autoprefixer
#8
Conversation
| this.enabled = this.options.enabled; | ||
| }, | ||
| postprocessTree: function(type, tree) { | ||
| var tree; |
There was a problem hiding this comment.
Won't this override the tree-variable passed in to the function?
There was a problem hiding this comment.
@kimroen Aghh good catch there, It was working so I presume it wasn't overriding but I should remove that var declaration
|
Thank you very much for doing this - I've been planning change the format and add tests for a while. I really appreciate it! |
|
@kimroen Yea no problem, just let me know about that |
|
@kimroen OK, I have addressed the comments |
|
@kimroen ping any update here? Are you hesitant to merge for some reason. I can make updates if you would like. |
|
I will merge this, I just haven't had the time to look it over properly and test yet. One thing though: I think it's better to check the actual generated files for the test instead of inspecting the elements in the running app. Something is absolutely better than nothing though :) |
|
This looks good! I'll merge it and update some stuff that has changed since this was created (like the QUnit syntax and other dependencies). Thank you again, and sorry for the delay! |
Update: `ember addon ember-cli-autoprefixer`
Updating the base addon configuration to adopt the newer
ember addon <name>generated style. This allows for testing and proper conventions. I also updated your License to be the non-line break MIT format with the updated year.Look it over and let me know if you like it 馃憤