Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @types/yargs to ^17.0.22 #168

Merged
merged 6 commits into from
Mar 20, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 23, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/yargs (source) ^17.0.13 -> ^17.0.22 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - "after 9pm,before 9am" in timezone Asia/Tokyo, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner November 23, 2022 19:32
@renovate renovate bot requested review from tasshi-me and removed request for a team November 23, 2022 19:32
@renovate renovate bot added the renovate label Nov 23, 2022
renovate-approve[bot]
renovate-approve bot previously approved these changes Nov 23, 2022
@renovate renovate bot changed the title chore(deps): update dependency @types/yargs to ^17.0.14 chore(deps): update dependency @types/yargs to ^17.0.15 Nov 28, 2022
@renovate renovate bot force-pushed the renovate/yargs-17.0.x branch 3 times, most recently from bbe3988 to 9e9f116 Compare December 5, 2022 16:30
@renovate renovate bot changed the title chore(deps): update dependency @types/yargs to ^17.0.15 chore(deps): update dependency @types/yargs to ^17.0.16 Dec 6, 2022
@tasshi-me
Copy link
Member

TODO: You can remove the Workaround of DefinitelyTyped/DefinitelyTyped#63396 in this PR.

@renovate renovate bot changed the title chore(deps): update dependency @types/yargs to ^17.0.16 chore(deps): update dependency @types/yargs to ^17.0.17 Dec 7, 2022
@renovate renovate bot force-pushed the renovate/yargs-17.0.x branch 7 times, most recently from eb618fb to f7a4019 Compare December 14, 2022 14:40
@renovate renovate bot changed the title chore(deps): update dependency @types/yargs to ^17.0.17 Update dependency @types/yargs to ^17.0.17 Dec 17, 2022
@renovate renovate bot changed the title Update dependency @types/yargs to ^17.0.17 chore(deps): update dependency @types/yargs to ^17.0.17 Dec 17, 2022
@renovate renovate bot force-pushed the renovate/yargs-17.0.x branch 4 times, most recently from fdb98f5 to 31eb407 Compare March 16, 2023 17:18
@renovate
Copy link
Contributor Author

renovate bot commented Mar 17, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@tasshi-me
Copy link
Member

tasshi-me commented Mar 17, 2023

The type of Array is default to (string | number)[].
So we need to specify string: true to make it string[] .

Error: src/cli/record/delete.ts(116,5): error TS2322: Type 'string | (string | number)[] | undefined' is not assignable to type 'string | string[] | undefined'.

https://github.com/kintone/cli-kintone/actions/runs/4447399767/jobs/7808898808#step:6:18

@tasshi-me
Copy link
Member

This error is caused by the bug of @types/yargs .

Error: src/cli/record/delete.ts(115,5): error TS2322: Type 'string | undefined' is not assignable to type 'string'.

https://github.com/kintone/cli-kintone/actions/runs/4447399767/jobs/7808898808#step:6:16

I reported it on DefinitelyTyped/DefinitelyTyped#64785 .

@tasshi-me
Copy link
Member

I checked the following issues are fixed.

$ cli-kintone-macos record import - #Strike TAB
 -- values --
--api-token                -- App's API token                                                                                                            
--app                      -- The ID of the app                                                                                                          
--attachments-dir          -- Attachment file directory                                                                                                  
--base-url                 -- Kintone Base Url                                                                                                           
--basic-auth-password      -- Kintone Basic Auth Password                                                                                                
--basic-auth-username      -- Kintone Basic Auth Username                                                                                                
--encoding                 -- Character encoding                                                                                                         
--fields                   -- The fields to be imported in comma-separated                                                                               
--file-path                -- The path to source file. The file extension should be ".csv"                                                               
--guest-space-id           -- The ID of guest space                                                                                                      
--help                     -- Show help                                                                                                                  
--password             -p  -- Kintone Password                                                                                                           
--pfx-file-password        -- The password of client certificate file                                                                                    
--pfx-file-path            -- The path to client certificate file                                                                                        
--proxy                    -- The URL of a proxy server                                                                                                  
--update-key               -- The key to Bulk Update                                                                                                     
--username             -u  -- Kintone Username                                                                                                           
--version                  -- Show version number  

tasshi-me
tasshi-me previously approved these changes Mar 17, 2023
@tasshi-me tasshi-me requested review from tasshi-me and renovate-approve and removed request for renovate-approve March 17, 2023 13:26
@tasshi-me tasshi-me dismissed stale reviews from renovate-approve and themself March 17, 2023 13:27

To prevent auto merge

@tasshi-me tasshi-me removed their request for review March 17, 2023 13:28
@tasshi-me tasshi-me self-assigned this Mar 17, 2023
Copy link
Contributor

@hung-cybo hung-cybo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hung-cybo hung-cybo merged commit 37f03c9 into main Mar 20, 2023
@hung-cybo hung-cybo deleted the renovate/yargs-17.0.x branch March 20, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants