-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the output of command completion is displayed incorrectly #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasshi-me
requested changes
Nov 25, 2022
tasshi-me
requested changes
Nov 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works well!
But it's good to do a little refactoring.
$ node ./cli.js --get-yargs-completions record import -
--version:Show version number
--help:Show help
--base-url:Kintone Base Url
--username:Kintone Username
--password:Kintone Password
--api-token:App's API token
--basic-auth-username:Kintone Basic Auth Username
--basic-auth-password:Kintone Basic Auth Password
--app:The ID of the app
--guest-space-id:The ID of guest space
--attachments-dir:Attachment file directory
--file-path:The path to source file. The file extension should be ".csv"
--encoding:Character encoding
--update-key:The key to Bulk Update
--fields:The fields to be imported in comma-separated
--pfx-file-path:The path to client certificate file
--pfx-file-password:The password of client certificate file
--proxy:The URL of a proxy server
tasshi-me
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
This was referenced Nov 28, 2022
This was referenced Jan 17, 2024
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently, the output of command completion is displayed incorrectly.
What
How to test
Checklist
yarn lint
andyarn test
on the root directory.