Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update jest monorepo to v28 (major) #1456

Merged
merged 7 commits into from May 19, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 25, 2022

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
babel-jest ^27.5.1 -> ^28.1.0 age adoption passing confidence
jest (source) ^27.5.1 -> ^28.1.0 age adoption passing confidence

Configuration

📅 Schedule: "after 9pm,before 9am" in timezone Asia/Tokyo.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, click this checkbox. ⚠ Warning: custom changes will be lost.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner April 25, 2022 13:40
@renovate renovate bot requested review from ueokande and tasshi-me and removed request for a team April 25, 2022 13:40
@renovate renovate bot added the renovate label Apr 25, 2022
@github-actions github-actions bot added the pkg: plugin-packer @kintone/plugin-packer label Apr 25, 2022
@renovate renovate bot force-pushed the renovate/major-jest-monorepo branch 6 times, most recently from 882675a to 2c0edfd Compare May 2, 2022 07:04
@renovate renovate bot force-pushed the renovate/major-jest-monorepo branch 3 times, most recently from ebeb82b to eff06cc Compare May 12, 2022 13:47
@renovate renovate bot force-pushed the renovate/major-jest-monorepo branch from eff06cc to 415b1de Compare May 15, 2022 17:06
From jestjs/jest#12689, jest passes `rootDir` option to babel-jest.
If rootDir is project sub-directory (e.g. `src/`, `__tests__/`),
babel cannot load babel.config.js in project root.
@tasshi-me
Copy link
Member

Cause

From jestjs/jest#12689, jest passes rootDir option to babel-jest.
If rootDir is project sub-directory (e.g. src/, __tests__/),
babel cannot load babel.config.js in project root.

Workarounds

Original error

https://github.com/kintone/js-sdk/runs/6442318372?check_suite_focus=true

$ jest --rootDir __tests__
FAIL __tests__/projectReferences.test.ts
  ● Test suite failed to run

    SyntaxError: /home/runner/work/js-sdk/js-sdk/__tests__/projectReferences.test.ts: Unexpected token, expected "," (33:30)

      31 |             assert.ok(
      32 |               referencePaths.some(
    > 33 |                 (referencePath: string) =>
         |                               ^
      34 |                   referencePath === getWorkspaceByName(dependency).packagePath
      35 |               ),
      36 |               `${packageName} doesn't have ${dependency} in the references field in tsconfig.json`

@tasshi-me
Copy link
Member

@tasshi-me tasshi-me self-assigned this May 17, 2022
@github-actions github-actions bot added pkg: create-plugin @kintone/create-plugin pkg: customize-uploader @kintone/customize-uploader pkg: data-loader @kintone/data-loader pkg: dts-gen @kintone/dts-gen pkg: plugin-manifest-validator @kintone/plugin-manifest-validator pkg: profile-loader @kintone/profile-loader pkg: rest-api-client @kintone/rest-api-client pkg: webpack-plugin-kintone-plugin @kintone/webpack-plugin-kintone-plugin labels May 17, 2022
@tasshi-me tasshi-me force-pushed the renovate/major-jest-monorepo branch from 75217ff to 992d8d2 Compare May 19, 2022 09:14
@tasshi-me tasshi-me merged commit 5e00e66 into master May 19, 2022
@tasshi-me tasshi-me deleted the renovate/major-jest-monorepo branch May 19, 2022 09:36
tasshi-me added a commit that referenced this pull request Jul 4, 2022
* chore(deps): update jest monorepo to v28

* test: fix jest.config.js

From jestjs/jest#12689, jest passes `rootDir` option to babel-jest.
If rootDir is project sub-directory (e.g. `src/`, `__tests__/`),
babel cannot load babel.config.js in project root.

* chore(rest-api-client): fix type error for dom (#1513)

* test(create-plugin): fix jest.config.js

* chore(rest-api-client): add type definition of Blob and BlobPart

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Masaharu TASHIRO <masatsr.kit@gmail.com>
Co-authored-by: tasshi / Masaharu TASHIRO <33759872+mshrtsr@users.noreply.github.com>
Co-authored-by: Masashi Hirano <shisama07@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: create-plugin @kintone/create-plugin pkg: customize-uploader @kintone/customize-uploader pkg: data-loader @kintone/data-loader pkg: dts-gen @kintone/dts-gen pkg: plugin-manifest-validator @kintone/plugin-manifest-validator pkg: plugin-packer @kintone/plugin-packer pkg: profile-loader @kintone/profile-loader pkg: rest-api-client @kintone/rest-api-client pkg: webpack-plugin-kintone-plugin @kintone/webpack-plugin-kintone-plugin renovate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants