Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rest-api-client): leverage IDE's intellisense in rollup.config.js #937

Merged
merged 3 commits into from Jun 15, 2021
Merged

chore(rest-api-client): leverage IDE's intellisense in rollup.config.js #937

merged 3 commits into from Jun 15, 2021

Conversation

tasshi-me
Copy link
Member

@tasshi-me tasshi-me commented Jun 8, 2021 •
edited

Why

rollup.defineConfig() is added in rollup v2.51.0.

With this function, we can leverage IDE's intellisense in rollup.config.js

What

How to test

$ yarn build
$ yarn lint
$ yarn test

Checklist

  • Read CONTRIBUTING.md
  • Updated documentation if it is required.
  • Added tests if it is required.
  • Passed yarn lint and yarn test on the root directory.

@tasshi-me tasshi-me added the pkg: rest-api-client @kintone/rest-api-client label Jun 8, 2021
@tasshi-me tasshi-me self-assigned this Jun 8, 2021
@tasshi-me tasshi-me marked this pull request as ready for review June 8, 2021 09:28
@tasshi-me tasshi-me requested a review from a team as a code owner June 8, 2021 09:28
@tasshi-me tasshi-me requested review from chick-p and shintaroNagata and removed request for a team June 8, 2021 09:28
chick-p
chick-p approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@chick-p chick-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@chick-p chick-p merged commit b10aeb3 into master Jun 15, 2021
@chick-p chick-p deleted the chore/leverage-intellisense-in-rollup-config branch June 15, 2021 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chick-p chick-p chick-p approved these changes

@shintaroNagata shintaroNagata Awaiting requested review from shintaroNagata

Assignees

@tasshi-me tasshi-me

Labels
pkg: rest-api-client @kintone/rest-api-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tasshi-me @chick-p