Check common_headers when running assertion #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping. Can you merge this? |
kiranz
reviewed
Jun 9, 2021
| @@ -469,7 +469,7 @@ export default class Spec { | |||
|
|
|||
| buildRequestBody(additionalOptions, headers, method) { | |||
| let bodyData = {}; | |||
| let requestContentType = headers['content-type']; | |||
| let requestContentType = headers['content-type'] || this.suite.commonHeaders['content-type']; | |||
There was a problem hiding this comment.
@matmar10 This is not required here, because the headers passed to this function include common headers too.
There was a problem hiding this comment.
I raised issue #31 because the current behavior does not include common headers set in config.
If you need, I can create a gist that reproduces this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #31